Re: [PATCH 3/3] extcon: ptn5150: Try to get usb role switch from connector fwnode

[Frank Li <Frank.li@nxp.com>]

On Wed, Apr 16, 2025 at 06:59:40PM +0800, Xu Yang wrote:
> Since PTN5150 is a Type-C chip, we normally need to describe some
> properties under connector node. Due to this, the port node will
> locate at connector node in the future. To support it, we need to
> get usb role switch via connector fwnode. For compatibility, this
> will not remove usb_role_switch_get() function.

Your patch 2 already return error if there not connector, which already
broken compatibility.

You should handle compatibility in patch 2 or before patch 2.

Frank
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
>  drivers/extcon/extcon-ptn5150.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
> index b7e05d921c79..160998e163f0 100644
> --- a/drivers/extcon/extcon-ptn5150.c
> +++ b/drivers/extcon/extcon-ptn5150.c
> @@ -352,6 +352,8 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c)
>  	}
>
>  	info->role_sw = usb_role_switch_get(info->dev);
> +	if (!info->role_sw && connector)
> +		info->role_sw = fwnode_usb_role_switch_get(connector);
>  	if (IS_ERR(info->role_sw))
>  		return dev_err_probe(info->dev, PTR_ERR(info->role_sw),
>  				     "failed to get role switch\n");
> --
> 2.34.1
>