From: Peng Fan <peng.fan@oss.nxp.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Brian Norris <briannorris@chromium.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
imx@lists.linux.dev
Subject: Re: [PATCH v1 19/23] pmdomain: imx: gpcv2: Discard pm_runtime_put() return value
Date: Tue, 23 Dec 2025 21:02:04 +0800 [thread overview]
Message-ID: <aUqSzEyuPgzPyrKo@shlinux89> (raw)
In-Reply-To: <15658107.tv2OnDr8pf@rafael.j.wysocki>
On Mon, Dec 22, 2025 at 09:29:41PM +0100, Rafael J. Wysocki wrote:
>From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
>Passing pm_runtime_put() return value to the callers is not particularly
>useful.
>
>Returning an error code from pm_runtime_put() merely means that it has
>not queued up a work item to check whether or not the device can be
>suspended and there are many perfectly valid situations in which that
>can happen, like after writing "on" to the devices' runtime PM "control"
>attribute in sysfs for one example.
>
>Accordingly, update imx_pgc_domain_suspend() to simply discard the
>return value of pm_runtime_put() and always return success to the
>caller.
>
>This will facilitate a planned change of the pm_runtime_put() return
>type to void in the future.
>
>Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Peng Fan <peng.fan@nxp.com>
next prev parent reply other threads:[~2025-12-23 13:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6245770.lOV4Wx5bFT@rafael.j.wysocki>
2025-12-22 20:18 ` [PATCH v1 13/23] phy: freescale: Discard pm_runtime_put() return value Rafael J. Wysocki
2025-12-22 20:29 ` [PATCH v1 19/23] pmdomain: imx: gpcv2: " Rafael J. Wysocki
2025-12-23 13:02 ` Peng Fan [this message]
2025-12-28 15:51 ` Ulf Hansson
2026-02-19 14:07 ` Rafael J. Wysocki
2026-02-20 16:05 ` Ulf Hansson
2026-02-20 16:58 ` Rafael J. Wysocki
2026-02-20 17:23 ` Rafael J. Wysocki
2026-02-21 11:24 ` Rafael J. Wysocki
2026-02-23 11:03 ` Ulf Hansson
2026-02-23 13:03 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUqSzEyuPgzPyrKo@shlinux89 \
--to=peng.fan@oss.nxp.com \
--cc=briannorris@chromium.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox