* [PATCH v1 13/23] phy: freescale: Discard pm_runtime_put() return value [not found] <6245770.lOV4Wx5bFT@rafael.j.wysocki> @ 2025-12-22 20:18 ` Rafael J. Wysocki 2025-12-22 20:29 ` [PATCH v1 19/23] pmdomain: imx: gpcv2: " Rafael J. Wysocki 1 sibling, 0 replies; 11+ messages in thread From: Rafael J. Wysocki @ 2025-12-22 20:18 UTC (permalink / raw) To: Linux PM Cc: LKML, Ulf Hansson, Brian Norris, Vinod Koul, Neil Armstrong, Shawn Guo, Sascha Hauer, Fabio Estevam, linux-phy, imx From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Printing error messages on pm_runtime_put() returning negative values is not particularly useful. Returning an error code from pm_runtime_put() merely means that it has not queued up a work item to check whether or not the device can be suspended and there are many perfectly valid situations in which that can happen, like after writing "on" to the devices' runtime PM "control" attribute in sysfs for one example. Accordingly, update mixel_lvds_phy_reset() to simply discard the return value of pm_runtime_put(). This will facilitate a planned change of the pm_runtime_put() return type to void in the future. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> --- This patch is part of a series, but it doesn't depend on anything else in that series. The last patch in the series depends on it. It can be applied by itself and if you decide to do so, please let me know. Otherwise, an ACK or equivalent will be appreciated, but also the lack of specific criticism will be eventually regarded as consent. --- drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c +++ b/drivers/phy/freescale/phy-fsl-imx8qm-lvds-phy.c @@ -286,11 +286,9 @@ static int mixel_lvds_phy_reset(struct d regmap_write(priv->regmap, PHY_CTRL, CTRL_RESET_VAL); - ret = pm_runtime_put(dev); - if (ret < 0) - dev_err(dev, "failed to put PM runtime: %d\n", ret); + pm_runtime_put(dev); - return ret; + return 0; } static struct phy *mixel_lvds_phy_xlate(struct device *dev, ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v1 19/23] pmdomain: imx: gpcv2: Discard pm_runtime_put() return value [not found] <6245770.lOV4Wx5bFT@rafael.j.wysocki> 2025-12-22 20:18 ` [PATCH v1 13/23] phy: freescale: Discard pm_runtime_put() return value Rafael J. Wysocki @ 2025-12-22 20:29 ` Rafael J. Wysocki 2025-12-23 13:02 ` Peng Fan 2025-12-28 15:51 ` Ulf Hansson 1 sibling, 2 replies; 11+ messages in thread From: Rafael J. Wysocki @ 2025-12-22 20:29 UTC (permalink / raw) To: Linux PM Cc: LKML, Ulf Hansson, Brian Norris, Shawn Guo, Sascha Hauer, Fabio Estevam, imx From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Passing pm_runtime_put() return value to the callers is not particularly useful. Returning an error code from pm_runtime_put() merely means that it has not queued up a work item to check whether or not the device can be suspended and there are many perfectly valid situations in which that can happen, like after writing "on" to the devices' runtime PM "control" attribute in sysfs for one example. Accordingly, update imx_pgc_domain_suspend() to simply discard the return value of pm_runtime_put() and always return success to the caller. This will facilitate a planned change of the pm_runtime_put() return type to void in the future. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> --- This patch is part of a series, but it doesn't depend on anything else in that series. The last patch in the series depends on it. It can be applied by itself and if you decide to do so, please let me know. Otherwise, an ACK or equivalent will be appreciated, but also the lack of specific criticism will be eventually regarded as consent. --- drivers/pmdomain/imx/gpcv2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/pmdomain/imx/gpcv2.c +++ b/drivers/pmdomain/imx/gpcv2.c @@ -1420,7 +1420,9 @@ static int imx_pgc_domain_suspend(struct static int imx_pgc_domain_resume(struct device *dev) { - return pm_runtime_put(dev); + pm_runtime_put(dev); + + return 0; } #endif ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 19/23] pmdomain: imx: gpcv2: Discard pm_runtime_put() return value 2025-12-22 20:29 ` [PATCH v1 19/23] pmdomain: imx: gpcv2: " Rafael J. Wysocki @ 2025-12-23 13:02 ` Peng Fan 2025-12-28 15:51 ` Ulf Hansson 1 sibling, 0 replies; 11+ messages in thread From: Peng Fan @ 2025-12-23 13:02 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Linux PM, LKML, Ulf Hansson, Brian Norris, Shawn Guo, Sascha Hauer, Fabio Estevam, imx On Mon, Dec 22, 2025 at 09:29:41PM +0100, Rafael J. Wysocki wrote: >From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > >Passing pm_runtime_put() return value to the callers is not particularly >useful. > >Returning an error code from pm_runtime_put() merely means that it has >not queued up a work item to check whether or not the device can be >suspended and there are many perfectly valid situations in which that >can happen, like after writing "on" to the devices' runtime PM "control" >attribute in sysfs for one example. > >Accordingly, update imx_pgc_domain_suspend() to simply discard the >return value of pm_runtime_put() and always return success to the >caller. > >This will facilitate a planned change of the pm_runtime_put() return >type to void in the future. > >Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Peng Fan <peng.fan@nxp.com> ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 19/23] pmdomain: imx: gpcv2: Discard pm_runtime_put() return value 2025-12-22 20:29 ` [PATCH v1 19/23] pmdomain: imx: gpcv2: " Rafael J. Wysocki 2025-12-23 13:02 ` Peng Fan @ 2025-12-28 15:51 ` Ulf Hansson 2026-02-19 14:07 ` Rafael J. Wysocki 1 sibling, 1 reply; 11+ messages in thread From: Ulf Hansson @ 2025-12-28 15:51 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Linux PM, LKML, Brian Norris, Shawn Guo, Sascha Hauer, Fabio Estevam, imx On Mon, 22 Dec 2025 at 21:37, Rafael J. Wysocki <rafael@kernel.org> wrote: > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Passing pm_runtime_put() return value to the callers is not particularly > useful. > > Returning an error code from pm_runtime_put() merely means that it has > not queued up a work item to check whether or not the device can be > suspended and there are many perfectly valid situations in which that > can happen, like after writing "on" to the devices' runtime PM "control" > attribute in sysfs for one example. > > Accordingly, update imx_pgc_domain_suspend() to simply discard the > return value of pm_runtime_put() and always return success to the > caller. > > This will facilitate a planned change of the pm_runtime_put() return > type to void in the future. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Applied for next, thanks! Kind regards Uffe > --- > > This patch is part of a series, but it doesn't depend on anything else > in that series. The last patch in the series depends on it. > > It can be applied by itself and if you decide to do so, please let me > know. > > Otherwise, an ACK or equivalent will be appreciated, but also the lack > of specific criticism will be eventually regarded as consent. > > --- > drivers/pmdomain/imx/gpcv2.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > --- a/drivers/pmdomain/imx/gpcv2.c > +++ b/drivers/pmdomain/imx/gpcv2.c > @@ -1420,7 +1420,9 @@ static int imx_pgc_domain_suspend(struct > > static int imx_pgc_domain_resume(struct device *dev) > { > - return pm_runtime_put(dev); > + pm_runtime_put(dev); > + > + return 0; > } > #endif > > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 19/23] pmdomain: imx: gpcv2: Discard pm_runtime_put() return value 2025-12-28 15:51 ` Ulf Hansson @ 2026-02-19 14:07 ` Rafael J. Wysocki 2026-02-20 16:05 ` Ulf Hansson 0 siblings, 1 reply; 11+ messages in thread From: Rafael J. Wysocki @ 2026-02-19 14:07 UTC (permalink / raw) To: Ulf Hansson Cc: Rafael J. Wysocki, Linux PM, LKML, Brian Norris, Shawn Guo, Sascha Hauer, Fabio Estevam, imx Hi Ulf, On Sun, Dec 28, 2025 at 4:52 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > On Mon, 22 Dec 2025 at 21:37, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > Passing pm_runtime_put() return value to the callers is not particularly > > useful. > > > > Returning an error code from pm_runtime_put() merely means that it has > > not queued up a work item to check whether or not the device can be > > suspended and there are many perfectly valid situations in which that > > can happen, like after writing "on" to the devices' runtime PM "control" > > attribute in sysfs for one example. > > > > Accordingly, update imx_pgc_domain_suspend() to simply discard the > > return value of pm_runtime_put() and always return success to the > > caller. > > > > This will facilitate a planned change of the pm_runtime_put() return > > type to void in the future. > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Applied for next, thanks! Since you applied this one, I'm assuming no objections, so I'm going to queue it up separately along with the patch changing pm_runtime_put() to void because I would prefer to make that change in 7.0 to dragging it for another cycle. An ACK would be helpful though, I think. > > --- > > > > This patch is part of a series, but it doesn't depend on anything else > > in that series. The last patch in the series depends on it. > > > > It can be applied by itself and if you decide to do so, please let me > > know. > > > > Otherwise, an ACK or equivalent will be appreciated, but also the lack > > of specific criticism will be eventually regarded as consent. > > > > --- > > drivers/pmdomain/imx/gpcv2.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > --- a/drivers/pmdomain/imx/gpcv2.c > > +++ b/drivers/pmdomain/imx/gpcv2.c > > @@ -1420,7 +1420,9 @@ static int imx_pgc_domain_suspend(struct > > > > static int imx_pgc_domain_resume(struct device *dev) > > { > > - return pm_runtime_put(dev); > > + pm_runtime_put(dev); > > + > > + return 0; > > } > > #endif > > > > > > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 19/23] pmdomain: imx: gpcv2: Discard pm_runtime_put() return value 2026-02-19 14:07 ` Rafael J. Wysocki @ 2026-02-20 16:05 ` Ulf Hansson 2026-02-20 16:58 ` Rafael J. Wysocki 0 siblings, 1 reply; 11+ messages in thread From: Ulf Hansson @ 2026-02-20 16:05 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Linux PM, LKML, Brian Norris, Shawn Guo, Sascha Hauer, Fabio Estevam, imx On Thu, 19 Feb 2026 at 15:07, Rafael J. Wysocki <rafael@kernel.org> wrote: > > Hi Ulf, > > On Sun, Dec 28, 2025 at 4:52 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > On Mon, 22 Dec 2025 at 21:37, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > > > Passing pm_runtime_put() return value to the callers is not particularly > > > useful. > > > > > > Returning an error code from pm_runtime_put() merely means that it has > > > not queued up a work item to check whether or not the device can be > > > suspended and there are many perfectly valid situations in which that > > > can happen, like after writing "on" to the devices' runtime PM "control" > > > attribute in sysfs for one example. > > > > > > Accordingly, update imx_pgc_domain_suspend() to simply discard the > > > return value of pm_runtime_put() and always return success to the > > > caller. > > > > > > This will facilitate a planned change of the pm_runtime_put() return > > > type to void in the future. > > > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > Applied for next, thanks! > > Since you applied this one, I'm assuming no objections, so I'm going > to queue it up separately along with the patch changing > pm_runtime_put() to void because I would prefer to make that change in > 7.0 to dragging it for another cycle. > > An ACK would be helpful though, I think. I was still hoping that Linus was considering to pull my pull-request for pmdomain, but it seems like that may happen. Assuming that doesn't change, I can re-base my next branch on Monday to drop $subject patch, but please wait until my confirmation so we don't end up having two commits in linux-next for the same change. Kind regards Uffe > > > > --- > > > > > > This patch is part of a series, but it doesn't depend on anything else > > > in that series. The last patch in the series depends on it. > > > > > > It can be applied by itself and if you decide to do so, please let me > > > know. > > > > > > Otherwise, an ACK or equivalent will be appreciated, but also the lack > > > of specific criticism will be eventually regarded as consent. > > > > > > --- > > > drivers/pmdomain/imx/gpcv2.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > --- a/drivers/pmdomain/imx/gpcv2.c > > > +++ b/drivers/pmdomain/imx/gpcv2.c > > > @@ -1420,7 +1420,9 @@ static int imx_pgc_domain_suspend(struct > > > > > > static int imx_pgc_domain_resume(struct device *dev) > > > { > > > - return pm_runtime_put(dev); > > > + pm_runtime_put(dev); > > > + > > > + return 0; > > > } > > > #endif > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 19/23] pmdomain: imx: gpcv2: Discard pm_runtime_put() return value 2026-02-20 16:05 ` Ulf Hansson @ 2026-02-20 16:58 ` Rafael J. Wysocki 2026-02-20 17:23 ` Rafael J. Wysocki 2026-02-23 11:03 ` Ulf Hansson 0 siblings, 2 replies; 11+ messages in thread From: Rafael J. Wysocki @ 2026-02-20 16:58 UTC (permalink / raw) To: Ulf Hansson Cc: Rafael J. Wysocki, Linux PM, LKML, Brian Norris, Shawn Guo, Sascha Hauer, Fabio Estevam, imx On Fri, Feb 20, 2026 at 5:06 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > On Thu, 19 Feb 2026 at 15:07, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > Hi Ulf, > > > > On Sun, Dec 28, 2025 at 4:52 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > > > On Mon, 22 Dec 2025 at 21:37, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > > > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > > > > > Passing pm_runtime_put() return value to the callers is not particularly > > > > useful. > > > > > > > > Returning an error code from pm_runtime_put() merely means that it has > > > > not queued up a work item to check whether or not the device can be > > > > suspended and there are many perfectly valid situations in which that > > > > can happen, like after writing "on" to the devices' runtime PM "control" > > > > attribute in sysfs for one example. > > > > > > > > Accordingly, update imx_pgc_domain_suspend() to simply discard the > > > > return value of pm_runtime_put() and always return success to the > > > > caller. > > > > > > > > This will facilitate a planned change of the pm_runtime_put() return > > > > type to void in the future. > > > > > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > > > Applied for next, thanks! > > > > Since you applied this one, I'm assuming no objections, so I'm going > > to queue it up separately along with the patch changing > > pm_runtime_put() to void because I would prefer to make that change in > > 7.0 to dragging it for another cycle. > > > > An ACK would be helpful though, I think. > > I was still hoping that Linus was considering to pull my pull-request > for pmdomain, but it seems like that may happen. Assuming that doesn't > change, I can re-base my next branch on Monday to drop $subject patch, > but please wait until my confirmation so we don't end up having two > commits in linux-next for the same change. Sure, no problem. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 19/23] pmdomain: imx: gpcv2: Discard pm_runtime_put() return value 2026-02-20 16:58 ` Rafael J. Wysocki @ 2026-02-20 17:23 ` Rafael J. Wysocki 2026-02-21 11:24 ` Rafael J. Wysocki 2026-02-23 11:03 ` Ulf Hansson 1 sibling, 1 reply; 11+ messages in thread From: Rafael J. Wysocki @ 2026-02-20 17:23 UTC (permalink / raw) To: Ulf Hansson Cc: Linux PM, LKML, Brian Norris, Shawn Guo, Sascha Hauer, Fabio Estevam, imx On Fri, Feb 20, 2026 at 5:58 PM Rafael J. Wysocki <rafael@kernel.org> wrote: > > On Fri, Feb 20, 2026 at 5:06 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > On Thu, 19 Feb 2026 at 15:07, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > > > Hi Ulf, > > > > > > On Sun, Dec 28, 2025 at 4:52 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > > > > > On Mon, 22 Dec 2025 at 21:37, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > > > > > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > > > > > > > Passing pm_runtime_put() return value to the callers is not particularly > > > > > useful. > > > > > > > > > > Returning an error code from pm_runtime_put() merely means that it has > > > > > not queued up a work item to check whether or not the device can be > > > > > suspended and there are many perfectly valid situations in which that > > > > > can happen, like after writing "on" to the devices' runtime PM "control" > > > > > attribute in sysfs for one example. > > > > > > > > > > Accordingly, update imx_pgc_domain_suspend() to simply discard the > > > > > return value of pm_runtime_put() and always return success to the > > > > > caller. > > > > > > > > > > This will facilitate a planned change of the pm_runtime_put() return > > > > > type to void in the future. > > > > > > > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > > > > > Applied for next, thanks! > > > > > > Since you applied this one, I'm assuming no objections, so I'm going > > > to queue it up separately along with the patch changing > > > pm_runtime_put() to void because I would prefer to make that change in > > > 7.0 to dragging it for another cycle. > > > > > > An ACK would be helpful though, I think. > > > > I was still hoping that Linus was considering to pull my pull-request > > for pmdomain, but it seems like that may happen. Assuming that doesn't > > change, I can re-base my next branch on Monday to drop $subject patch, > > but please wait until my confirmation so we don't end up having two > > commits in linux-next for the same change. > > Sure, no problem. That said, git can cope with merging two branches carrying exactly the same patch. It just creates an empty commit for the second copy AFAICS. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 19/23] pmdomain: imx: gpcv2: Discard pm_runtime_put() return value 2026-02-20 17:23 ` Rafael J. Wysocki @ 2026-02-21 11:24 ` Rafael J. Wysocki 0 siblings, 0 replies; 11+ messages in thread From: Rafael J. Wysocki @ 2026-02-21 11:24 UTC (permalink / raw) To: Ulf Hansson Cc: Linux PM, LKML, Brian Norris, Shawn Guo, Sascha Hauer, Fabio Estevam, imx On Fri, Feb 20, 2026 at 6:23 PM Rafael J. Wysocki <rafael@kernel.org> wrote: > > On Fri, Feb 20, 2026 at 5:58 PM Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > On Fri, Feb 20, 2026 at 5:06 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > > > On Thu, 19 Feb 2026 at 15:07, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > > > > > Hi Ulf, > > > > > > > > On Sun, Dec 28, 2025 at 4:52 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > > > > > > > On Mon, 22 Dec 2025 at 21:37, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > > > > > > > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > > > > > > > > > Passing pm_runtime_put() return value to the callers is not particularly > > > > > > useful. > > > > > > > > > > > > Returning an error code from pm_runtime_put() merely means that it has > > > > > > not queued up a work item to check whether or not the device can be > > > > > > suspended and there are many perfectly valid situations in which that > > > > > > can happen, like after writing "on" to the devices' runtime PM "control" > > > > > > attribute in sysfs for one example. > > > > > > > > > > > > Accordingly, update imx_pgc_domain_suspend() to simply discard the > > > > > > return value of pm_runtime_put() and always return success to the > > > > > > caller. > > > > > > > > > > > > This will facilitate a planned change of the pm_runtime_put() return > > > > > > type to void in the future. > > > > > > > > > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > > > > > > > Applied for next, thanks! > > > > > > > > Since you applied this one, I'm assuming no objections, so I'm going > > > > to queue it up separately along with the patch changing > > > > pm_runtime_put() to void because I would prefer to make that change in > > > > 7.0 to dragging it for another cycle. > > > > > > > > An ACK would be helpful though, I think. > > > > > > I was still hoping that Linus was considering to pull my pull-request > > > for pmdomain, but it seems like that may happen. Assuming that doesn't > > > change, I can re-base my next branch on Monday to drop $subject patch, > > > but please wait until my confirmation so we don't end up having two > > > commits in linux-next for the same change. > > > > Sure, no problem. > > That said, git can cope with merging two branches carrying exactly the > same patch. It just creates an empty commit for the second copy > AFAICS. A correction on the latter: That's what rebase would do, if I'm not mistaken. A merge simply doesn't update files that are already identical in both parents. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 19/23] pmdomain: imx: gpcv2: Discard pm_runtime_put() return value 2026-02-20 16:58 ` Rafael J. Wysocki 2026-02-20 17:23 ` Rafael J. Wysocki @ 2026-02-23 11:03 ` Ulf Hansson 2026-02-23 13:03 ` Rafael J. Wysocki 1 sibling, 1 reply; 11+ messages in thread From: Ulf Hansson @ 2026-02-23 11:03 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Linux PM, LKML, Brian Norris, Shawn Guo, Sascha Hauer, Fabio Estevam, imx On Fri, 20 Feb 2026 at 17:58, Rafael J. Wysocki <rafael@kernel.org> wrote: > > On Fri, Feb 20, 2026 at 5:06 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > On Thu, 19 Feb 2026 at 15:07, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > > > Hi Ulf, > > > > > > On Sun, Dec 28, 2025 at 4:52 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > > > > > On Mon, 22 Dec 2025 at 21:37, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > > > > > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > > > > > > > Passing pm_runtime_put() return value to the callers is not particularly > > > > > useful. > > > > > > > > > > Returning an error code from pm_runtime_put() merely means that it has > > > > > not queued up a work item to check whether or not the device can be > > > > > suspended and there are many perfectly valid situations in which that > > > > > can happen, like after writing "on" to the devices' runtime PM "control" > > > > > attribute in sysfs for one example. > > > > > > > > > > Accordingly, update imx_pgc_domain_suspend() to simply discard the > > > > > return value of pm_runtime_put() and always return success to the > > > > > caller. > > > > > > > > > > This will facilitate a planned change of the pm_runtime_put() return > > > > > type to void in the future. > > > > > > > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > > > > > Applied for next, thanks! > > > > > > Since you applied this one, I'm assuming no objections, so I'm going > > > to queue it up separately along with the patch changing > > > pm_runtime_put() to void because I would prefer to make that change in > > > 7.0 to dragging it for another cycle. > > > > > > An ACK would be helpful though, I think. > > > > I was still hoping that Linus was considering to pull my pull-request > > for pmdomain, but it seems like that may happen. Assuming that doesn't > > change, I can re-base my next branch on Monday to drop $subject patch, > > but please wait until my confirmation so we don't end up having two > > commits in linux-next for the same change. > > Sure, no problem. I have updated my next branch and dropped the $subject patch from it. Please add my ack when applying. Acked-by: Ulf Hansson <ulf.hansson@linaro.org> Kind regards Uffe ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 19/23] pmdomain: imx: gpcv2: Discard pm_runtime_put() return value 2026-02-23 11:03 ` Ulf Hansson @ 2026-02-23 13:03 ` Rafael J. Wysocki 0 siblings, 0 replies; 11+ messages in thread From: Rafael J. Wysocki @ 2026-02-23 13:03 UTC (permalink / raw) To: Ulf Hansson Cc: Rafael J. Wysocki, Linux PM, LKML, Brian Norris, Shawn Guo, Sascha Hauer, Fabio Estevam, imx On Mon, Feb 23, 2026 at 12:04 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > On Fri, 20 Feb 2026 at 17:58, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > On Fri, Feb 20, 2026 at 5:06 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > > > On Thu, 19 Feb 2026 at 15:07, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > > > > > Hi Ulf, > > > > > > > > On Sun, Dec 28, 2025 at 4:52 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > > > > > > > On Mon, 22 Dec 2025 at 21:37, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > > > > > > > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > > > > > > > > > Passing pm_runtime_put() return value to the callers is not particularly > > > > > > useful. > > > > > > > > > > > > Returning an error code from pm_runtime_put() merely means that it has > > > > > > not queued up a work item to check whether or not the device can be > > > > > > suspended and there are many perfectly valid situations in which that > > > > > > can happen, like after writing "on" to the devices' runtime PM "control" > > > > > > attribute in sysfs for one example. > > > > > > > > > > > > Accordingly, update imx_pgc_domain_suspend() to simply discard the > > > > > > return value of pm_runtime_put() and always return success to the > > > > > > caller. > > > > > > > > > > > > This will facilitate a planned change of the pm_runtime_put() return > > > > > > type to void in the future. > > > > > > > > > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > > > > > > > Applied for next, thanks! > > > > > > > > Since you applied this one, I'm assuming no objections, so I'm going > > > > to queue it up separately along with the patch changing > > > > pm_runtime_put() to void because I would prefer to make that change in > > > > 7.0 to dragging it for another cycle. > > > > > > > > An ACK would be helpful though, I think. > > > > > > I was still hoping that Linus was considering to pull my pull-request > > > for pmdomain, but it seems like that may happen. Assuming that doesn't > > > change, I can re-base my next branch on Monday to drop $subject patch, > > > but please wait until my confirmation so we don't end up having two > > > commits in linux-next for the same change. > > > > Sure, no problem. > > I have updated my next branch and dropped the $subject patch from it. > Please add my ack when applying. > > Acked-by: Ulf Hansson <ulf.hansson@linaro.org> Thanks! ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2026-02-23 13:03 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <6245770.lOV4Wx5bFT@rafael.j.wysocki>
2025-12-22 20:18 ` [PATCH v1 13/23] phy: freescale: Discard pm_runtime_put() return value Rafael J. Wysocki
2025-12-22 20:29 ` [PATCH v1 19/23] pmdomain: imx: gpcv2: " Rafael J. Wysocki
2025-12-23 13:02 ` Peng Fan
2025-12-28 15:51 ` Ulf Hansson
2026-02-19 14:07 ` Rafael J. Wysocki
2026-02-20 16:05 ` Ulf Hansson
2026-02-20 16:58 ` Rafael J. Wysocki
2026-02-20 17:23 ` Rafael J. Wysocki
2026-02-21 11:24 ` Rafael J. Wysocki
2026-02-23 11:03 ` Ulf Hansson
2026-02-23 13:03 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox