From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Alan Stern <stern@rowland.harvard.edu>, Xu Yang <xu.yang_2@nxp.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
gregkh@linuxfoundation.org, tglx@kernel.org, mingo@kernel.org,
claudiu.beznea.uj@bp.renesas.com, kees@kernel.org,
bigeasy@linutronix.de, ulf.hansson@linaro.org,
rafael.j.wysocki@intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
jun.li@nxp.com
Subject: Re: [PATCH] usb: hcd: queue wakeup_work to system_freezable_wq workqueue
Date: Thu, 5 Mar 2026 23:18:29 +0200 [thread overview]
Message-ID: <aad2d38e-a0ef-49b1-a82e-f3a9b4750612@linux.intel.com> (raw)
In-Reply-To: <b5a3d627-8cc5-41a9-848a-1e67c96bc191@rowland.harvard.edu>
On 3/5/26 17:47, Alan Stern wrote:
>
>>> A better question to ask would be: Why does xhci_resume() call
>>> usb_hcd_resume_root_hub()? That does not seem like the right thing to
>>> do -- at least, not in this scenario. The proper time to resume the
>>> root hub after a system sleep is when the PM core calls its resume
>>> routine.
>>
>> Good question, it seems like commit 79989bd4ab86 ("xhci: always resume
>> roothubs if xHC was reset during resume") is added to fix some issues.
>
> The changelog for that commit says that it was meant to take care of
> problems during runtime resume, but it also affects system resume. This
> appears to be an oversight.
That is possible
We should probably limit the all the usb_hcd_resume_root_hub() calls in
xhci_resume() to runtime resume cases only.
There is a similar case further down in xhci_resume() where driver is looking
for pending port events.
Thanks
Mathias
prev parent reply other threads:[~2026-03-05 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 11:57 [PATCH] usb: hcd: queue wakeup_work to system_freezable_wq workqueue Xu Yang
2026-03-04 15:24 ` Alan Stern
2026-03-05 7:18 ` Xu Yang
2026-03-05 15:47 ` Alan Stern
2026-03-05 21:18 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aad2d38e-a0ef-49b1-a82e-f3a9b4750612@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jun.li@nxp.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mingo@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tglx@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox