[PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure

[PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure

[Pan Chuang]

Commit 55b48e23f5c4b6f5ca9b7ab09599b17dcf501c10 ("genirq/devres: Add
error handling in devm_request_*_irq()") added automatic error logging
to devm_request_threaded_irq() and devm_request_any_context_irq() via
the new devm_request_result() helper. The helper prints device name,
IRQ number, handler functions, and error code on failure.

Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this automatic
logging.

This series removes the now-redundant dev_err() and dev_err_probe() calls
in dmaengine drivers that follow these devm_request_*_irq() functions,
as the core now provides more detailed diagnostic information on failure.

Pan Chuang (26):
  dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe()
  dmaengine: fsl-qdma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: loongson-loongson1-apb-dma: Remove redundant
    dev_err()/dev_err_probe()
  dmaengine: mediatek-mtk-cqdma: Remove redundant
    dev_err()/dev_err_probe()
  dmaengine: mediatek-mtk-hsdma: Remove redundant
    dev_err()/dev_err_probe()
  dmaengine: mmp_pdma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: moxart-dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: owl-dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: pxa_dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: qcom-gpi: Remove redundant dev_err()/dev_err_probe()
  dmaengine: sf-pdma-sf-pdma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: sh-rcar-dmac: Remove redundant dev_err()/dev_err_probe()
  dmaengine: sh-rz-dmac: Remove redundant dev_err()/dev_err_probe()
  dmaengine: sh-shdmac: Remove redundant dev_err()/dev_err_probe()
  dmaengine: sh-usb-dmac: Remove redundant dev_err()/dev_err_probe()
  dmaengine: sprd-dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: st_fdma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: stm32-stm32-dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: stm32-stm32-dma3: Remove redundant
    dev_err()/dev_err_probe()
  dmaengine: stm32-stm32-mdma: Remove redundant
    dev_err()/dev_err_probe()
  dmaengine: sun4i-dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: sun6i-dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: tegra20-apb-dma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: ti-edma: Remove redundant dev_err()/dev_err_probe()
  dmaengine: uniphier-xdmac: Remove redundant dev_err()/dev_err_probe()
  dmaengine: xgene-dma: Remove redundant dev_err()/dev_err_probe()

 drivers/dma/fsl-edma-main.c              | 23 +++++++----------------
 drivers/dma/fsl-qdma.c                   |  4 +---
 drivers/dma/loongson/loongson1-apb-dma.c |  4 +---
 drivers/dma/mediatek/mtk-cqdma.c         |  5 +----
 drivers/dma/mediatek/mtk-hsdma.c         |  5 +----
 drivers/dma/mmp_pdma.c                   |  4 +---
 drivers/dma/moxart-dma.c                 |  4 +---
 drivers/dma/owl-dma.c                    |  4 +---
 drivers/dma/pxa_dma.c                    |  6 +-----
 drivers/dma/qcom/gpi.c                   |  5 +----
 drivers/dma/sf-pdma/sf-pdma.c            |  8 ++------
 drivers/dma/sh/rcar-dmac.c               |  5 +----
 drivers/dma/sh/rz-dmac.c                 |  8 +-------
 drivers/dma/sh/shdmac.c                  |  6 +-----
 drivers/dma/sh/usb-dmac.c                |  5 +----
 drivers/dma/sprd-dma.c                   |  4 +---
 drivers/dma/st_fdma.c                    |  4 +---
 drivers/dma/stm32/stm32-dma.c            |  6 +-----
 drivers/dma/stm32/stm32-dma3.c           |  5 +----
 drivers/dma/stm32/stm32-mdma.c           |  4 +---
 drivers/dma/sun4i-dma.c                  |  2 +-
 drivers/dma/sun6i-dma.c                  |  4 +---
 drivers/dma/tegra20-apb-dma.c            |  6 +-----
 drivers/dma/ti/edma.c                    |  8 ++------
 drivers/dma/uniphier-xdmac.c             |  4 +---
 drivers/dma/xgene-dma.c                  |  5 +----
 26 files changed, 34 insertions(+), 114 deletions(-)

-- 
2.34.1

[PATCH 01/26] dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe()

[Pan Chuang]

The devm_request_irq() now automatically logs detailed error messages on
failure. This eliminates the need for driver-specific dev_err() and
dev_err_probe() calls that previously printed generic messages.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/dma/fsl-edma-main.c | 23 +++++++----------------
 1 file changed, 7 insertions(+), 16 deletions(-)

diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
index 36155ab1602a..0881f4f36b3f 100644
--- a/drivers/dma/fsl-edma-main.c
+++ b/drivers/dma/fsl-edma-main.c
@@ -357,24 +357,18 @@ fsl_edma_irq_init(struct platform_device *pdev, struct fsl_edma_engine *fsl_edma
 	if (fsl_edma->txirq == fsl_edma->errirq) {
 		ret = devm_request_irq(&pdev->dev, fsl_edma->txirq,
 				fsl_edma_irq_handler, 0, "eDMA", fsl_edma);
-		if (ret) {
-			dev_err(&pdev->dev, "Can't register eDMA IRQ.\n");
+		if (ret)
 			return ret;
-		}
 	} else {
 		ret = devm_request_irq(&pdev->dev, fsl_edma->txirq,
 				fsl_edma_tx_handler, 0, "eDMA tx", fsl_edma);
-		if (ret) {
-			dev_err(&pdev->dev, "Can't register eDMA tx IRQ.\n");
+		if (ret)
 			return ret;
-		}
 
 		ret = devm_request_irq(&pdev->dev, fsl_edma->errirq,
 				fsl_edma_err_handler, 0, "eDMA err", fsl_edma);
-		if (ret) {
-			dev_err(&pdev->dev, "Can't register eDMA err IRQ.\n");
+		if (ret)
 			return ret;
-		}
 	}
 
 	return 0;
@@ -418,7 +412,7 @@ static int fsl_edma3_irq_init(struct platform_device *pdev, struct fsl_edma_engi
 		ret = devm_request_irq(&pdev->dev, fsl_edma->errirq, fsl_edma3_err_handler_shared,
 				       0, errirq_name, fsl_edma);
 		if (ret)
-			return dev_err_probe(&pdev->dev, ret, "Can't register eDMA err IRQ.\n");
+			return ret;
 	}
 
 	return 0;
@@ -445,24 +439,21 @@ static int fsl_edma3_or_irq_init(struct platform_device *pdev,
 			       fsl_edma3_tx_0_15_handler, 0, "eDMA tx0_15",
 			       fsl_edma);
 	if (ret)
-		return dev_err_probe(&pdev->dev, ret,
-			       "Can't register eDMA tx0_15 IRQ.\n");
+		return ret;
 
 	if (fsl_edma->n_chans > 16) {
 		ret = devm_request_irq(&pdev->dev, fsl_edma->txirq_16_31,
 				       fsl_edma3_tx_16_31_handler, 0,
 				       "eDMA tx16_31", fsl_edma);
 		if (ret)
-			return dev_err_probe(&pdev->dev, ret,
-					"Can't register eDMA tx16_31 IRQ.\n");
+			return ret;
 	}
 
 	ret = devm_request_irq(&pdev->dev, fsl_edma->errirq,
 			       fsl_edma3_or_err_handler, 0, "eDMA err",
 			       fsl_edma);
 	if (ret)
-		return dev_err_probe(&pdev->dev, ret,
-				     "Can't register eDMA err IRQ.\n");
+		return ret;
 
 	return 0;
 }
-- 
2.34.1

Re: [PATCH 01/26] dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe()

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:

Pre-existing issues:
- [High] The txirq_16_31 interrupt is not freed before vchan cleanup, leading to a race condition and potential use-after-free on device unbind.
- [High] Double disable/unprepare of devm-managed clocks during the probe failure path.
- [High] Probe deferral is permanently broken due to unconditionally overriding negative error codes from `platform_get_irq()` with `-EINVAL` or `-ENXIO`.
--

--- Patch [1]: [PATCH 01/26] dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe() ---
commit 0e4d4c4909fc6ed60a790a7b9fecb3bf5b716c3b
Author: Pan Chuang <panchuang@vivo.com>

    dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe()
    
    The devm_request_irq() now automatically logs detailed error messages on
    failure. This eliminates the need for driver-specific dev_err() and
    dev_err_probe() calls that previously printed generic messages.

> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index 36155ab1602a9..0881f4f36b3f4 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c
[ ... ]
> @@ -418,7 +412,7 @@ static int fsl_edma3_irq_init(struct platform_device *pdev, struct fsl_edma_engi
>  		ret = devm_request_irq(&pdev->dev, fsl_edma->errirq, fsl_edma3_err_handler_shared,
>  				       0, errirq_name, fsl_edma);
>  		if (ret)
> -			return dev_err_probe(&pdev->dev, ret, "Can't register eDMA err IRQ.\n");
> +			return ret;

[Severity: High]
This is a pre-existing issue, but probe deferral appears to be permanently
broken for the interrupt requests in this function and fsl_edma2_irq_init().

In fsl_edma3_irq_init(), if platform_get_irq() returns -EPROBE_DEFER,
the error code is discarded and replaced with -EINVAL:

    fsl_chan->txirq = platform_get_irq(pdev, i);
    if (fsl_chan->txirq < 0)
        return -EINVAL;

Similarly in fsl_edma2_irq_init(), it replaces the error with -ENXIO:

    irq = platform_get_irq(pdev, i);
    ret = 0;
    if (irq < 0)
        return -ENXIO;

Could this prevent the DMA engine from probing on systems where the
interrupt controller is not yet ready?

>  	}
>  
>  	return 0;
> @@ -445,24 +439,21 @@ static int fsl_edma3_or_irq_init(struct platform_device *pdev,
>  			       fsl_edma3_tx_0_15_handler, 0, "eDMA tx0_15",
>  			       fsl_edma);
>  	if (ret)
> -		return dev_err_probe(&pdev->dev, ret,
> -			       "Can't register eDMA tx0_15 IRQ.\n");
> +		return ret;
>  
>  	if (fsl_edma->n_chans > 16) {
>  		ret = devm_request_irq(&pdev->dev, fsl_edma->txirq_16_31,
>  				       fsl_edma3_tx_16_31_handler, 0,
>  				       "eDMA tx16_31", fsl_edma);
>  		if (ret)
> -			return dev_err_probe(&pdev->dev, ret,
> -					"Can't register eDMA tx16_31 IRQ.\n");
> +			return ret;

[Severity: High]
This isn't a bug introduced by this patch, but does the handling of
txirq_16_31 create a race condition leading to a potential use-after-free?

When the driver is unbound, fsl_edma_remove() executes:

    fsl_edma_irq_exit(pdev, fsl_edma);
    fsl_edma_cleanup_vchan(&fsl_edma->dma_dev);

However, fsl_edma_irq_exit() manually frees txirq and errirq to stop
interrupts before vchan cleanup, but it misses txirq_16_31:

    if (fsl_edma->txirq == fsl_edma->errirq) {
        if (fsl_edma->txirq >= 0)
            devm_free_irq(&pdev->dev, fsl_edma->txirq, fsl_edma);
    } else {
        if (fsl_edma->txirq >= 0)
            devm_free_irq(&pdev->dev, fsl_edma->txirq, fsl_edma);
        if (fsl_edma->errirq >= 0)
            devm_free_irq(&pdev->dev, fsl_edma->errirq, fsl_edma);
    }

Since txirq_16_31 is not freed, is it possible for the interrupt handler
to still run during or after fsl_edma_cleanup_vchan() destroys the vchan
tasklets?

>  	}
>  
>  	ret = devm_request_irq(&pdev->dev, fsl_edma->errirq,
>  			       fsl_edma3_or_err_handler, 0, "eDMA err",
>  			       fsl_edma);
>  	if (ret)
> -		return dev_err_probe(&pdev->dev, ret,
> -				     "Can't register eDMA err IRQ.\n");
> +		return ret;
>  
>  	return 0;
>  }

[Severity: High]
This isn't a bug introduced by this patch, but is there a double disable of
devm-managed clocks during the probe failure path?

In fsl_edma_probe(), the mux clocks are acquired using the devm variant:

    fsl_edma->muxclk[i] = devm_clk_get_enabled(&pdev->dev, clkname);

If resource mapping fails for a subsequent mux base, the error path manually
disables the clocks:

    if (IS_ERR(fsl_edma->muxbase[i])) {
        /* on error: disable all previously enabled clks */
        fsl_disable_clocks(fsl_edma, i);
        return PTR_ERR(fsl_edma->muxbase[i]);
    }

Because the clocks were acquired with devm_clk_get_enabled(), won't devres
also try to disable them when cleaning up the probe failure, resulting in a
double-disable?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709135846.97972-1-panchuang@vivo.com?part=1

Re: [PATCH 01/26] dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe()

[Frank Li]

On Thu, Jul 09, 2026 at 09:58:05PM +0800, Pan Chuang wrote:
> The devm_request_irq() now automatically logs detailed error messages on
> failure. This eliminates the need for driver-specific dev_err() and
> dev_err_probe() calls that previously printed generic messages.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  drivers/dma/fsl-edma-main.c | 23 +++++++----------------
>  1 file changed, 7 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index 36155ab1602a..0881f4f36b3f 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c
> @@ -357,24 +357,18 @@ fsl_edma_irq_init(struct platform_device *pdev, struct fsl_edma_engine *fsl_edma
>  	if (fsl_edma->txirq == fsl_edma->errirq) {
>  		ret = devm_request_irq(&pdev->dev, fsl_edma->txirq,
>  				fsl_edma_irq_handler, 0, "eDMA", fsl_edma);
> -		if (ret) {
> -			dev_err(&pdev->dev, "Can't register eDMA IRQ.\n");
> +		if (ret)
>  			return ret;
> -		}
>  	} else {
>  		ret = devm_request_irq(&pdev->dev, fsl_edma->txirq,
>  				fsl_edma_tx_handler, 0, "eDMA tx", fsl_edma);
> -		if (ret) {
> -			dev_err(&pdev->dev, "Can't register eDMA tx IRQ.\n");
> +		if (ret)
>  			return ret;
> -		}
>
>  		ret = devm_request_irq(&pdev->dev, fsl_edma->errirq,
>  				fsl_edma_err_handler, 0, "eDMA err", fsl_edma);
> -		if (ret) {
> -			dev_err(&pdev->dev, "Can't register eDMA err IRQ.\n");
> +		if (ret)
>  			return ret;
> -		}
>  	}
>
>  	return 0;
> @@ -418,7 +412,7 @@ static int fsl_edma3_irq_init(struct platform_device *pdev, struct fsl_edma_engi
>  		ret = devm_request_irq(&pdev->dev, fsl_edma->errirq, fsl_edma3_err_handler_shared,
>  				       0, errirq_name, fsl_edma);
>  		if (ret)
> -			return dev_err_probe(&pdev->dev, ret, "Can't register eDMA err IRQ.\n");
> +			return ret;
>  	}
>
>  	return 0;
> @@ -445,24 +439,21 @@ static int fsl_edma3_or_irq_init(struct platform_device *pdev,
>  			       fsl_edma3_tx_0_15_handler, 0, "eDMA tx0_15",
>  			       fsl_edma);
>  	if (ret)
> -		return dev_err_probe(&pdev->dev, ret,
> -			       "Can't register eDMA tx0_15 IRQ.\n");
> +		return ret;
>
>  	if (fsl_edma->n_chans > 16) {
>  		ret = devm_request_irq(&pdev->dev, fsl_edma->txirq_16_31,
>  				       fsl_edma3_tx_16_31_handler, 0,
>  				       "eDMA tx16_31", fsl_edma);
>  		if (ret)
> -			return dev_err_probe(&pdev->dev, ret,
> -					"Can't register eDMA tx16_31 IRQ.\n");
> +			return ret;
>  	}
>
>  	ret = devm_request_irq(&pdev->dev, fsl_edma->errirq,
>  			       fsl_edma3_or_err_handler, 0, "eDMA err",
>  			       fsl_edma);
>  	if (ret)
> -		return dev_err_probe(&pdev->dev, ret,
> -				     "Can't register eDMA err IRQ.\n");
> +		return ret;
>
>  	return 0;
>  }
> --
> 2.34.1
>
>

Re: [PATCH 00/26] dmaengine: Remove redundant error messages on IRQ request failure

[Wolfram Sang]

On Thu, Jul 09, 2026 at 09:58:04PM +0800, Pan Chuang wrote:
> Commit 55b48e23f5c4b6f5ca9b7ab09599b17dcf501c10 ("genirq/devres: Add
> error handling in devm_request_*_irq()") added automatic error logging
> to devm_request_threaded_irq() and devm_request_any_context_irq() via
> the new devm_request_result() helper. The helper prints device name,
> IRQ number, handler functions, and error code on failure.
> 
> Since devm_request_irq() is a static inline wrapper around
> devm_request_threaded_irq(), it also benefits from this automatic
> logging.
> 
> This series removes the now-redundant dev_err() and dev_err_probe() calls
> in dmaengine drivers that follow these devm_request_*_irq() functions,
> as the core now provides more detailed diagnostic information on failure.
> 
> Pan Chuang (26):
>   dmaengine: fsl-edma-main: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: fsl-qdma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: loongson-loongson1-apb-dma: Remove redundant
>     dev_err()/dev_err_probe()
>   dmaengine: mediatek-mtk-cqdma: Remove redundant
>     dev_err()/dev_err_probe()
>   dmaengine: mediatek-mtk-hsdma: Remove redundant
>     dev_err()/dev_err_probe()
>   dmaengine: mmp_pdma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: moxart-dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: owl-dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: pxa_dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: qcom-gpi: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: sf-pdma-sf-pdma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: sh-rcar-dmac: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: sh-rz-dmac: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: sh-shdmac: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: sh-usb-dmac: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: sprd-dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: st_fdma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: stm32-stm32-dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: stm32-stm32-dma3: Remove redundant
>     dev_err()/dev_err_probe()
>   dmaengine: stm32-stm32-mdma: Remove redundant
>     dev_err()/dev_err_probe()
>   dmaengine: sun4i-dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: sun6i-dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: tegra20-apb-dma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: ti-edma: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: uniphier-xdmac: Remove redundant dev_err()/dev_err_probe()
>   dmaengine: xgene-dma: Remove redundant dev_err()/dev_err_probe()

One patch per subsystem for such trivial changes, please.