From: Andrew Lunn <andrew@lunn.ch>
To: Fabio Estevam <festevam@gmail.com>
Cc: Frank Li <Frank.Li@nxp.com>, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Stefan Wahren <wahrenst@gmx.net>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
imx@lists.linux.dev
Subject: Re: [PATCH v4 1/1] dt-bindings: net: convert qca,qca7000.txt yaml format
Date: Tue, 17 Jun 2025 18:52:58 +0200 [thread overview]
Message-ID: <c4864e76-cec3-4794-825d-cc9ccbf92e43@lunn.ch> (raw)
In-Reply-To: <CAOMZO5DwJ9bk26TBU46_fU0ydwQL__dxUoOULuKyZYWRdbJ0YQ@mail.gmail.com>
On Tue, Jun 17, 2025 at 01:09:21PM -0300, Fabio Estevam wrote:
> On Mon, Jun 16, 2025 at 3:48 PM Frank Li <Frank.Li@nxp.com> wrote:
>
> > +examples:
> > + - |
> > + spi {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + ethernet@0 {
> > + compatible = "qca,qca7000";
> > + reg = <0x0>;
> > + interrupt-parent = <&gpio3>; /* GPIO Bank 3 */
> > + interrupts = <25 0x1>; /* Index: 25, rising edge */
> > + spi-cpha; /* SPI mode: CPHA=1 */
> > + spi-cpol; /* SPI mode: CPOL=1 */
> > + spi-max-frequency = <8000000>; /* freq: 8 MHz */
>
> All of these comments are obvious and don't bring any new information.
>
> I recommend dropping all of them.
I would also suggest replacing 0x1 with IRQ_TYPE_EDGE_RISING.
Andrew
prev parent reply other threads:[~2025-06-17 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 18:48 [PATCH v4 1/1] dt-bindings: net: convert qca,qca7000.txt yaml format Frank Li
2025-06-16 22:32 ` Jacob Keller
2025-06-17 6:45 ` Krzysztof Kozlowski
2025-06-17 16:09 ` Fabio Estevam
2025-06-17 16:52 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4864e76-cec3-4794-825d-cc9ccbf92e43@lunn.ch \
--to=andrew@lunn.ch \
--cc=Frank.Li@nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox