* [PATCH v4 1/3] arm64: dts: freescale: imx93-var-som: Fix resource table address
2026-11-20 18:32 [PATCH v4 0/3] arm64: dts: freescale: imx93-var: Add Cortex-M33 configurations Stefano Radaelli
@ 2026-11-20 18:32 ` Stefano Radaelli
2026-11-20 18:32 ` [PATCH v4 2/3] arm64: dts: freescale: imx93-var: Extract common Cortex-M33 configuration Stefano Radaelli
2026-11-20 18:32 ` [PATCH v4 3/3] arm64: dts: freescale: imx93-var: Add Cortex-M33 configurations Stefano Radaelli
2 siblings, 0 replies; 6+ messages in thread
From: Stefano Radaelli @ 2026-11-20 18:32 UTC (permalink / raw)
To: Frank Li, linux-kernel, devicetree, imx, linux-arm-kernel
Cc: pierluigi.p, Stefano Radaelli, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Mathieu Othacehe
From: Stefano Radaelli <stefano.r@variscite.com>
The VAR-SOM-MX93 RPMsg firmware copies its resource table to M33 address
0x2001e000, which maps to 0x2021e000 in the Cortex-A55 address space.
The reserved-memory node instead points one page later, at 0x2021f000,
so remoteproc can look for the loaded table at the wrong address.
Use 0x2021e000 with the existing 4 KiB size to match the firmware.
This also matches the resource table address used by DART-MX93.
Fixes: 4ce623d9f1bf ("arm64: dts: imx93-var-som: Add Variscite VAR-SOM-MX93")
Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
---
Changes in v4:
- New patch: fix the Symphony resource table address before extracting
the common configuration.
arch/arm64/boot/dts/freescale/imx93-var-som-symphony.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx93-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx93-var-som-symphony.dts
index 1f0954620195..78b19d8918b7 100644
--- a/arch/arm64/boot/dts/freescale/imx93-var-som-symphony.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-var-som-symphony.dts
@@ -107,8 +107,8 @@ vdev1vring1: vdev1vring1@87ef8000 {
no-map;
};
- rsc_table: rsc-table@2021f000 {
- reg = <0 0x2021f000 0 0x1000>;
+ rsc_table: rsc-table@2021e000 {
+ reg = <0 0x2021e000 0 0x1000>;
no-map;
};
--
2.47.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v4 2/3] arm64: dts: freescale: imx93-var: Extract common Cortex-M33 configuration
2026-11-20 18:32 [PATCH v4 0/3] arm64: dts: freescale: imx93-var: Add Cortex-M33 configurations Stefano Radaelli
2026-11-20 18:32 ` [PATCH v4 1/3] arm64: dts: freescale: imx93-var-som: Fix resource table address Stefano Radaelli
@ 2026-11-20 18:32 ` Stefano Radaelli
2026-11-20 18:32 ` [PATCH v4 3/3] arm64: dts: freescale: imx93-var: Add Cortex-M33 configurations Stefano Radaelli
2 siblings, 0 replies; 6+ messages in thread
From: Stefano Radaelli @ 2026-11-20 18:32 UTC (permalink / raw)
To: Frank Li, linux-kernel, devicetree, imx, linux-arm-kernel
Cc: pierluigi.p, Stefano Radaelli, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Mathieu Othacehe
From: Stefano Radaelli <stefano.r@variscite.com>
Move the Cortex-M33 reserved memory and remoteproc configuration into a
common include shared by DART-MX93 and VAR-SOM-MX93.
Include the common file from both module DTSI files.
Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
---
Changes in v4:
- Move the resource table, RPMsg vrings and shared buffer from both
carrier DTS files into the common include.
- Use generic memory@ node names and move memory-region-names from the
overlay patch into this patch.
- Include the common configuration from both module DTSI files.
Changes in v3:
- Split the common configuration extraction into a separate patch,
preserving the existing DART-MX93 configuration.
This patch uses the following binding and driver commits, already in
linux-next:
- ebb21cc5d1c0 ("dt-bindings: remoteproc: imx_rproc: Document
memory-region-names to avoid implicit ABI")
- 8396089f91fa ("remoteproc: imx_rpoc: Use memory-region-names to avoid
implicit ABI")
.../dts/freescale/imx93-var-common-m33.dtsi | 65 +++++++++++++++++++
.../dts/freescale/imx93-var-dart-sonata.dts | 31 ---------
.../boot/dts/freescale/imx93-var-dart.dtsi | 15 +----
.../dts/freescale/imx93-var-som-symphony.dts | 31 ---------
.../boot/dts/freescale/imx93-var-som.dtsi | 1 +
5 files changed, 67 insertions(+), 76 deletions(-)
create mode 100644 arch/arm64/boot/dts/freescale/imx93-var-common-m33.dtsi
diff --git a/arch/arm64/boot/dts/freescale/imx93-var-common-m33.dtsi b/arch/arm64/boot/dts/freescale/imx93-var-common-m33.dtsi
new file mode 100644
index 000000000000..72b47ba99cb9
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx93-var-common-m33.dtsi
@@ -0,0 +1,65 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Common Cortex-M33 configuration for Variscite i.MX93 modules
+ *
+ * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com/
+ *
+ */
+
+&{/} {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ rsc_table: memory@2021e000 {
+ reg = <0 0x2021e000 0 0x1000>;
+ no-map;
+ };
+
+ vdev0vring0: memory@87ee0000 {
+ reg = <0 0x87ee0000 0 0x8000>;
+ no-map;
+ };
+
+ vdev0vring1: memory@87ee8000 {
+ reg = <0 0x87ee8000 0 0x8000>;
+ no-map;
+ };
+
+ vdev1vring0: memory@87ef0000 {
+ reg = <0 0x87ef0000 0 0x8000>;
+ no-map;
+ };
+
+ vdev1vring1: memory@87ef8000 {
+ reg = <0 0x87ef8000 0 0x8000>;
+ no-map;
+ };
+
+ vdevbuffer: memory@87f00000 {
+ compatible = "shared-dma-pool";
+ reg = <0 0x87f00000 0 0x100000>;
+ no-map;
+ };
+ };
+};
+
+&cm33 {
+ mbox-names = "tx", "rx", "rxdb";
+ mboxes = <&mu1 0 1
+ &mu1 1 1
+ &mu1 3 1>;
+ memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>,
+ <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>;
+ memory-region-names = "vdev0buffer", "vdev0vring0", "vdev0vring1",
+ "vdev1vring0", "vdev1vring1", "rsc-table";
+ status = "okay";
+};
+
+&mu1 {
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata.dts b/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata.dts
index 1ca3ec8330d0..efd51f6364f3 100644
--- a/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata.dts
@@ -137,37 +137,6 @@ ethosu_mem: ethosu-region@88000000 {
reg = <0x0 0x88000000 0x0 0x8000000>;
};
- vdev0vring0: vdev0vring0@87ee0000 {
- reg = <0 0x87ee0000 0 0x8000>;
- no-map;
- };
-
- vdev0vring1: vdev0vring1@87ee8000 {
- reg = <0 0x87ee8000 0 0x8000>;
- no-map;
- };
-
- vdev1vring0: vdev1vring0@87ef0000 {
- reg = <0 0x87ef0000 0 0x8000>;
- no-map;
- };
-
- vdev1vring1: vdev1vring1@87ef8000 {
- reg = <0 0x87ef8000 0 0x8000>;
- no-map;
- };
-
- rsc_table: rsc-table@2021e000 {
- reg = <0 0x2021e000 0 0x1000>;
- no-map;
- };
-
- vdevbuffer: vdevbuffer@87f00000 {
- compatible = "shared-dma-pool";
- reg = <0 0x87f00000 0 0x100000>;
- no-map;
- };
-
ele_reserved: ele-reserved@87de0000 {
compatible = "shared-dma-pool";
reg = <0 0x87de0000 0 0x100000>;
diff --git a/arch/arm64/boot/dts/freescale/imx93-var-dart.dtsi b/arch/arm64/boot/dts/freescale/imx93-var-dart.dtsi
index 69495bb7fc9f..4ee4d74cadea 100644
--- a/arch/arm64/boot/dts/freescale/imx93-var-dart.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93-var-dart.dtsi
@@ -12,6 +12,7 @@
#include <dt-bindings/usb/pd.h>
#include "imx93.dtsi"
+#include "imx93-var-common-m33.dtsi"
/ {
model = "Variscite DART-MX93 Module";
@@ -54,16 +55,6 @@ wifi_pwrseq: wifi-pwrseq {
};
};
-&cm33 {
- mbox-names = "tx", "rx", "rxdb";
- mboxes = <&mu1 0 1>,
- <&mu1 1 1>,
- <&mu1 3 1>;
- memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>,
- <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>;
- status = "okay";
-};
-
&eqos {
pinctrl-names = "default", "sleep";
pinctrl-0 = <&pinctrl_eqos>;
@@ -221,10 +212,6 @@ bluetooth {
};
};
-&mu1 {
- status = "okay";
-};
-
&mu2 {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/freescale/imx93-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx93-var-som-symphony.dts
index 78b19d8918b7..c3e880025a06 100644
--- a/arch/arm64/boot/dts/freescale/imx93-var-som-symphony.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-var-som-symphony.dts
@@ -87,37 +87,6 @@ ethosu_mem: ethosu-region@88000000 {
reg = <0x0 0x88000000 0x0 0x8000000>;
};
- vdev0vring0: vdev0vring0@87ee0000 {
- reg = <0 0x87ee0000 0 0x8000>;
- no-map;
- };
-
- vdev0vring1: vdev0vring1@87ee8000 {
- reg = <0 0x87ee8000 0 0x8000>;
- no-map;
- };
-
- vdev1vring0: vdev1vring0@87ef0000 {
- reg = <0 0x87ef0000 0 0x8000>;
- no-map;
- };
-
- vdev1vring1: vdev1vring1@87ef8000 {
- reg = <0 0x87ef8000 0 0x8000>;
- no-map;
- };
-
- rsc_table: rsc-table@2021e000 {
- reg = <0 0x2021e000 0 0x1000>;
- no-map;
- };
-
- vdevbuffer: vdevbuffer@87f00000 {
- compatible = "shared-dma-pool";
- reg = <0 0x87f00000 0 0x100000>;
- no-map;
- };
-
ele_reserved: ele-reserved@87de0000 {
compatible = "shared-dma-pool";
reg = <0 0x87de0000 0 0x100000>;
diff --git a/arch/arm64/boot/dts/freescale/imx93-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx93-var-som.dtsi
index b0ffcb534cb6..46b739a147e3 100644
--- a/arch/arm64/boot/dts/freescale/imx93-var-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93-var-som.dtsi
@@ -7,6 +7,7 @@
/dts-v1/;
#include "imx93.dtsi"
+#include "imx93-var-common-m33.dtsi"
/{
model = "Variscite VAR-SOM-MX93 module";
--
2.47.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v4 3/3] arm64: dts: freescale: imx93-var: Add Cortex-M33 configurations
2026-11-20 18:32 [PATCH v4 0/3] arm64: dts: freescale: imx93-var: Add Cortex-M33 configurations Stefano Radaelli
2026-11-20 18:32 ` [PATCH v4 1/3] arm64: dts: freescale: imx93-var-som: Fix resource table address Stefano Radaelli
2026-11-20 18:32 ` [PATCH v4 2/3] arm64: dts: freescale: imx93-var: Extract common Cortex-M33 configuration Stefano Radaelli
@ 2026-11-20 18:32 ` Stefano Radaelli
2026-11-20 18:44 ` sashiko-bot
2 siblings, 1 reply; 6+ messages in thread
From: Stefano Radaelli @ 2026-11-20 18:32 UTC (permalink / raw)
To: Frank Li, linux-kernel, devicetree, imx, linux-arm-kernel
Cc: pierluigi.p, Stefano Radaelli, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Mathieu Othacehe
From: Stefano Radaelli <stefano.r@variscite.com>
Add Cortex-M33 overlays and combined DTBs for DART-MX93 on Sonata and
VAR-SOM-MX93 on Symphony.
Include the common configuration only from the overlays, so the M33
memory regions are reserved and remoteproc and MU1 are enabled only in
the M33 variants. Use the -m33 DTB when remoteproc support is needed.
Mark the peripherals used by the M33 firmware as reserved. Disable Wi-Fi,
Bluetooth and the devices depending on GPIO4. On Sonata, also disable USB
OTG1 because its USB-C role controller is unavailable.
Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
---
Changes in v4:
- Move memory-region-names to the common configuration extraction patch.
- Remove the common include from both module DTSI files, so the M33
memory regions are now reserved only in the M33 variants.
Changes in v3:
- Move the common configuration extraction to patch 1.
- Use "reserved" for peripherals assigned to the M33 firmware; keep
"disabled" for dependent devices.
Changes in v2:
- Enable cm33 and MU1 only through the M33 overlay on DART-MX93.
arch/arm64/boot/dts/freescale/Makefile | 9 +++
.../freescale/imx93-var-dart-sonata-m33.dtso | 55 +++++++++++++++++++
.../dts/freescale/imx93-var-dart-sonata.dts | 2 +-
.../boot/dts/freescale/imx93-var-dart.dtsi | 1 -
.../freescale/imx93-var-som-symphony-m33.dtso | 50 +++++++++++++++++
.../boot/dts/freescale/imx93-var-som.dtsi | 1 -
6 files changed, 115 insertions(+), 3 deletions(-)
create mode 100644 arch/arm64/boot/dts/freescale/imx93-var-dart-sonata-m33.dtso
create mode 100644 arch/arm64/boot/dts/freescale/imx93-var-som-symphony-m33.dtso
diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index cfd548284358..05a7556e9de9 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -956,8 +956,17 @@ dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxca-lvds-tm070jvhg33.dtb
dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla-lvds-tm070jvhg33.dtb
dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla-mini-ezurio-wlan.dtb
dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla-mini-lvds-tm070jvhg33.dtb
+
+imx93-var-dart-sonata-m33-dtbs := imx93-var-dart-sonata.dtb imx93-var-dart-sonata-m33.dtbo
dtb-$(CONFIG_ARCH_MXC) += imx93-var-dart-sonata.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx93-var-dart-sonata-m33.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx93-var-dart-sonata-m33.dtbo
+
+imx93-var-som-symphony-m33-dtbs := imx93-var-som-symphony.dtb imx93-var-som-symphony-m33.dtbo
dtb-$(CONFIG_ARCH_MXC) += imx93-var-som-symphony.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx93-var-som-symphony-m33.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx93-var-som-symphony-m33.dtbo
+
dtb-$(CONFIG_ARCH_MXC) += imx93w-evk.dtb
dtb-$(CONFIG_ARCH_MXC) += imx93w-frdm.dtb
dtb-$(CONFIG_ARCH_MXC) += imx943-evk.dtb
diff --git a/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata-m33.dtso b/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata-m33.dtso
new file mode 100644
index 000000000000..51ec0beea7c9
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata-m33.dtso
@@ -0,0 +1,55 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Cortex-M33 support for Variscite DART-MX93 on Sonata-Board
+ *
+ * Link: https://variscite.com/carrier-boards/sonata-board/
+ *
+ * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com/
+ *
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include "imx93-var-common-m33.dtsi"
+
+/* Reserve the peripherals used by the Cortex-M33 firmware. */
+&flexcan1 {
+ status = "reserved";
+};
+
+&gpio4 {
+ status = "reserved";
+};
+
+&lpspi5 {
+ status = "reserved";
+};
+
+/* Disable Bluetooth along with Wi-Fi and release the JTAG pins. */
+&lpuart5 {
+ status = "disabled";
+};
+
+&lpuart7 {
+ status = "reserved";
+};
+
+/* The USB-C role controller uses an interrupt on GPIO4. */
+&ptn5150 {
+ status = "disabled";
+};
+
+/* The USB-C role controller is unavailable. */
+&usbotg1 {
+ status = "disabled";
+};
+
+/* Wi-Fi reset is connected to GPIO4. */
+&usdhc3 {
+ status = "disabled";
+};
+
+&wifi_pwrseq {
+ status = "disabled";
+};
diff --git a/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata.dts b/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata.dts
index efd51f6364f3..57007f716f22 100644
--- a/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata.dts
@@ -260,7 +260,7 @@ ft5x06_ts: touchscreen@38 {
};
/* USB Type-C Controller */
- typec@3d {
+ ptn5150: typec@3d {
compatible = "nxp,ptn5150";
reg = <0x3d>;
interrupt-parent = <&gpio4>;
diff --git a/arch/arm64/boot/dts/freescale/imx93-var-dart.dtsi b/arch/arm64/boot/dts/freescale/imx93-var-dart.dtsi
index 4ee4d74cadea..6c596d61bd21 100644
--- a/arch/arm64/boot/dts/freescale/imx93-var-dart.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93-var-dart.dtsi
@@ -12,7 +12,6 @@
#include <dt-bindings/usb/pd.h>
#include "imx93.dtsi"
-#include "imx93-var-common-m33.dtsi"
/ {
model = "Variscite DART-MX93 Module";
diff --git a/arch/arm64/boot/dts/freescale/imx93-var-som-symphony-m33.dtso b/arch/arm64/boot/dts/freescale/imx93-var-som-symphony-m33.dtso
new file mode 100644
index 000000000000..8df03ed3c004
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx93-var-som-symphony-m33.dtso
@@ -0,0 +1,50 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Cortex-M33 support for Variscite VAR-SOM-MX93 on Symphony-Board
+ *
+ * Link: https://variscite.com/carrier-boards/symphony-board/
+ *
+ * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com/
+ *
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include "imx93-var-common-m33.dtsi"
+
+/* The resistive touchscreen uses GPIO4. */
+&ads7846 {
+ status = "disabled";
+};
+
+/* Reserve the peripherals used by the Cortex-M33 firmware. */
+&flexcan1 {
+ status = "reserved";
+};
+
+&gpio4 {
+ status = "reserved";
+};
+
+&lpspi6 {
+ status = "reserved";
+};
+
+/* Disable Bluetooth along with Wi-Fi and release the JTAG pins. */
+&lpuart5 {
+ status = "disabled";
+};
+
+&lpuart7 {
+ status = "reserved";
+};
+
+/* Wi-Fi reset is connected to GPIO4. */
+&usdhc3 {
+ status = "disabled";
+};
+
+&usdhc3_pwrseq {
+ status = "disabled";
+};
diff --git a/arch/arm64/boot/dts/freescale/imx93-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx93-var-som.dtsi
index 46b739a147e3..b0ffcb534cb6 100644
--- a/arch/arm64/boot/dts/freescale/imx93-var-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93-var-som.dtsi
@@ -7,7 +7,6 @@
/dts-v1/;
#include "imx93.dtsi"
-#include "imx93-var-common-m33.dtsi"
/{
model = "Variscite VAR-SOM-MX93 module";
--
2.47.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v4 3/3] arm64: dts: freescale: imx93-var: Add Cortex-M33 configurations
2026-11-20 18:32 ` [PATCH v4 3/3] arm64: dts: freescale: imx93-var: Add Cortex-M33 configurations Stefano Radaelli
@ 2026-11-20 18:44 ` sashiko-bot
2026-11-20 18:47 ` Stefano Radaelli
0 siblings, 1 reply; 6+ messages in thread
From: sashiko-bot @ 2026-11-20 18:44 UTC (permalink / raw)
To: Stefano Radaelli, devicetree, imx; +Cc: robh, conor+dt, Frank.Li
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: freescale: imx93-var: memory@ node names break
imx_rproc matching
--
commit 3b76dce88eb56af58d06bc8653db1a91c42100e4
Author: Stefano Radaelli <stefano.r@variscite.com>
arm64: dts: freescale: imx93-var: Add Cortex-M33 configurations
This commit adds Cortex-M33 overlays and combined DTBs for DART-MX93 on Sonata
and VAR-SOM-MX93 on Symphony, moving the common M33 include into the overlays
and reserving or disabling affected peripherals.
> diff --git a/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata-m33.dtso b/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata-m33.dtso
> new file mode 100644
> index 0000000000000..51ec0beea7c9f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata-m33.dtso
> @@ -0,0 +1,55 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Cortex-M33 support for Variscite DART-MX93 on Sonata-Board
> + *
> + * Link: https://variscite.com/carrier-boards/sonata-board/
> + *
> + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com/
> + *
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include "imx93-var-common-m33.dtsi"
[Severity: High]
Does imx_rproc recognize the reserved-memory regions included from
imx93-var-common-m33.dtsi (both here and in
imx93-var-som-symphony-m33.dtso)?
imx93-var-common-m33.dtsi names the reserved-memory nodes memory@2021e000,
memory@87ee0000, etc., and puts the region names in memory-region-names on
&cm33:
arch/arm64/boot/dts/freescale/imx93-var-common-m33.dtsi:
reserved-memory {
...
rsc_table: memory@2021e000 {
...
&cm33 {
...
memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>,
<&vdev1vring0>, <&vdev1vring1>, <&rsc_table>;
memory-region-names = "vdev0buffer", "vdev0vring0", "vdev0vring1",
"vdev1vring0", "vdev1vring1", "rsc-table";
However, imx_rproc_addr_init() and imx_rproc_prepare() look up regions by
index with of_reserved_mem_region_to_resource(), which sets res.name to
the /reserved-memory node name rather than reading memory-region-names:
drivers/remoteproc/imx_rproc.c:imx_rproc_prepare() {
...
if (strstarts(res.name, "vdev0buffer"))
continue;
if (strstarts(res.name, "rsc-table"))
continue;
...
mem = rproc_mem_entry_init(priv->dev, NULL, (dma_addr_t)res.start,
resource_size(&res), da,
rproc_mem_entry_ioremap_wc,
rproc_mem_entry_iounmap,
"%.*s", strchrnul(res.name, '@') - res.name,
res.name);
Because res.name starts with "memory@", imx_rproc_addr_init() leaves
priv->rsc_table NULL and ioremaps the vdev regions, while
imx_rproc_prepare() registers all six carveouts under the name "memory",
so rproc_alloc_vring() fails to find the "vdev%dvring%d" carveouts at
runtime. In addition, fsl,imx-rproc.yaml does not allow
memory-region-names on the remoteproc node, causing dtbs_check failures on
the new -m33 DTBs.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795197853.git.stefano.r@variscite.com?part=3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4 3/3] arm64: dts: freescale: imx93-var: Add Cortex-M33 configurations
2026-11-20 18:44 ` sashiko-bot
@ 2026-11-20 18:47 ` Stefano Radaelli
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Radaelli @ 2026-11-20 18:47 UTC (permalink / raw)
To: sashiko-reviews; +Cc: devicetree, imx, robh, conor+dt, Frank.Li
On Fri, Nov 20, 2026 at 06:44:28PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] arm64: dts: freescale: imx93-var: memory@ node names break
> imx_rproc matching
> --
>
> commit 3b76dce88eb56af58d06bc8653db1a91c42100e4
> Author: Stefano Radaelli <stefano.r@variscite.com>
>
> arm64: dts: freescale: imx93-var: Add Cortex-M33 configurations
>
> This commit adds Cortex-M33 overlays and combined DTBs for DART-MX93 on Sonata
> and VAR-SOM-MX93 on Symphony, moving the common M33 include into the overlays
> and reserving or disabling affected peripherals.
>
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata-m33.dtso b/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata-m33.dtso
> > new file mode 100644
> > index 0000000000000..51ec0beea7c9f
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx93-var-dart-sonata-m33.dtso
> > @@ -0,0 +1,55 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Cortex-M33 support for Variscite DART-MX93 on Sonata-Board
> > + *
> > + * Link: https://variscite.com/carrier-boards/sonata-board/
> > + *
> > + * Copyright (C) 2026 Variscite Ltd. - https://www.variscite.com/
> > + *
> > + */
> > +
> > +/dts-v1/;
> > +/plugin/;
> > +
> > +#include "imx93-var-common-m33.dtsi"
>
> [Severity: High]
> Does imx_rproc recognize the reserved-memory regions included from
> imx93-var-common-m33.dtsi (both here and in
> imx93-var-som-symphony-m33.dtso)?
>
> imx93-var-common-m33.dtsi names the reserved-memory nodes memory@2021e000,
> memory@87ee0000, etc., and puts the region names in memory-region-names on
> &cm33:
>
> arch/arm64/boot/dts/freescale/imx93-var-common-m33.dtsi:
> reserved-memory {
> ...
> rsc_table: memory@2021e000 {
> ...
> &cm33 {
> ...
> memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>,
> <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>;
> memory-region-names = "vdev0buffer", "vdev0vring0", "vdev0vring1",
> "vdev1vring0", "vdev1vring1", "rsc-table";
>
> However, imx_rproc_addr_init() and imx_rproc_prepare() look up regions by
> index with of_reserved_mem_region_to_resource(), which sets res.name to
> the /reserved-memory node name rather than reading memory-region-names:
>
> drivers/remoteproc/imx_rproc.c:imx_rproc_prepare() {
> ...
> if (strstarts(res.name, "vdev0buffer"))
> continue;
>
> if (strstarts(res.name, "rsc-table"))
> continue;
> ...
> mem = rproc_mem_entry_init(priv->dev, NULL, (dma_addr_t)res.start,
> resource_size(&res), da,
> rproc_mem_entry_ioremap_wc,
> rproc_mem_entry_iounmap,
> "%.*s", strchrnul(res.name, '@') - res.name,
> res.name);
>
> Because res.name starts with "memory@", imx_rproc_addr_init() leaves
> priv->rsc_table NULL and ioremaps the vdev regions, while
> imx_rproc_prepare() registers all six carveouts under the name "memory",
> so rproc_alloc_vring() fails to find the "vdev%dvring%d" carveouts at
> runtime. In addition, fsl,imx-rproc.yaml does not allow
> memory-region-names on the remoteproc node, causing dtbs_check failures on
> the new -m33 DTBs.
>
This series depends on the following commits, already in linux-next,
as noted in the cover letter and in patch 2:
- ebb21cc5d1c0 ("dt-bindings: remoteproc: imx_rproc: Document
memory-region-names to avoid implicit ABI")
- 8396089f91fa ("remoteproc: imx_rpoc: Use memory-region-names to avoid
implicit ABI")
The driver change replaces the direct calls to
of_reserved_mem_region_to_resource() in both imx_rproc_prepare() and
imx_rproc_addr_init() with imx_rproc_rmem_to_resource(), which reads
memory-region-names into res.name. The binding change permits that
property.
With these prerequisites applied, the generic memory@ node names do
not affect resource table or vring matching.
The reported issue applies when the series is evaluated without those
prerequisites. This series needs to be applied after them.
Thanks,
Stefano
^ permalink raw reply [flat|nested] 6+ messages in thread