From: Marek Vasut <marex@nabladev.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: linux-arm-kernel@lists.infradead.org,
Fedor Ross <fedor.ross@ifm.com>,
Christian Eggers <ceggers@arri.de>,
Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Markus Heidelberg <m.heidelberg@cab.de>,
Rob Herring <robh@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard v1 and v2
Date: Tue, 30 Dec 2025 14:34:14 +0100 [thread overview]
Message-ID: <dc29e774-07fb-4d0e-a88a-27d4ec49d060@nabladev.com> (raw)
In-Reply-To: <e3d305ce-cdfa-4a11-bd54-9648b12a013f@lunn.ch>
On 12/30/25 11:46 AM, Andrew Lunn wrote:
>> +&fec1 {
>> + fsl,magic-packet;
>
> Upps, i probably cut out too much context. This FEC is connected to the Ethernet switch.
>
> WoL for a port connected to a switch? Have you tested this? Normally
> you would have WoL on each port of the switch, and not on the conduit
> interface.
>
>> +&fec1 {
>> + fsl,magic-packet;
>
> Have you tested WoL?
>
>> +&fec1 {
>> + fsl,magic-packet;
>
> WoL again?
I don't think WOL is used on this device at all. Would you suggest
removing the fsl,magic-packet properties ?
next prev parent reply other threads:[~2025-12-30 14:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 19:36 [PATCH v2 1/4] dt-bindings: vendor-prefixes: Document ifm electronic gmbh Marek Vasut
2025-12-29 19:36 ` [PATCH v2 2/4] dt-bindings: arm: fsl: Document ifm VHIP4 EvalBoard v1 and v2 Marek Vasut
2025-12-29 19:36 ` [PATCH v2 3/4] arm64: dts: imx8mn: Add SNVS LPGPR Marek Vasut
2025-12-29 19:36 ` [PATCH v2 4/4] arm64: dts: imx8mn: Add ifm VHIP4 EvalBoard v1 and v2 Marek Vasut
2025-12-30 10:46 ` Andrew Lunn
2025-12-30 13:34 ` Marek Vasut [this message]
2025-12-30 15:35 ` Andrew Lunn
2025-12-30 18:42 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc29e774-07fb-4d0e-a88a-27d4ec49d060@nabladev.com \
--to=marex@nabladev.com \
--cc=andrew@lunn.ch \
--cc=ceggers@arri.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fedor.ross@ifm.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.heidelberg@cab.de \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox