From: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Clark Wang <xiaoning.wang@nxp.com>,
Linux Team <linux-imx@nxp.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 0/3] arm64: mx93: etherrnet: set TX_CLK in RMII mode
Date: Mon, 22 Apr 2024 11:28:08 +0200 [thread overview]
Message-ID: <f01d49cf-5955-405c-9c2b-05b0c7bb982c@armadeus.com> (raw)
In-Reply-To: <20240422-v6-9-topic-imx93-eqos-rmii-v1-0-30151fca43d2@pengutronix.de>
Hello,
On 4/22/24 10:46, Steffen Trumtrar wrote:
> This series adds support for setting the TX_CLK direction in the eQOS
> ethernet core on the i.MX93 when RMII mode is used.
>
> According to AN14149, when the i.MX93 ethernet controller is used in
> RMII mode, the TX_CLK *must* be set to output mode.
Must ? I don't think that is true. Downstream NXP kernel has an option
to set TX_CLK as an input:
https://github.com/nxp-imx/linux-imx/blob/lf-6.6.y/Documentation/devicetree/bindings/net/nxp%2Cdwmac-imx.yaml#L69
https://github.com/nxp-imx/linux-imx/commit/fbc17f6f7919d03c275fc48b0400c212475b60ec
Regards,
>
> Add a devicetree property with the register to set this bit and parse it
> in the dwmac-imx driver.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> Steffen Trumtrar (3):
> dt-bindings: net: mx93: add enet_clk_sel binding
> arm64: dts: imx93: add enet_clk_sel
> net: stmicro: imx: set TX_CLK direction in RMII mode
>
> .../devicetree/bindings/net/nxp,dwmac-imx.yaml | 10 ++++++++
> arch/arm64/boot/dts/freescale/imx93.dtsi | 1 +
> drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c | 27 ++++++++++++++++++++++
> 3 files changed, 38 insertions(+)
> ---
> base-commit: 4cece764965020c22cff7665b18a012006359095
> change-id: 20240422-v6-9-topic-imx93-eqos-rmii-3a2cb421c81d
>
> Best regards,
--
Sébastien Szymanski, Armadeus Systems
Software engineer
next prev parent reply other threads:[~2024-04-22 10:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 8:46 [PATCH 0/3] arm64: mx93: etherrnet: set TX_CLK in RMII mode Steffen Trumtrar
2024-04-22 8:46 ` [PATCH 1/3] dt-bindings: net: mx93: add enet_clk_sel binding Steffen Trumtrar
2024-04-22 8:58 ` Sascha Hauer
2024-04-23 6:46 ` Steffen Trumtrar
2024-04-22 9:11 ` Krzysztof Kozlowski
2024-04-22 9:11 ` Krzysztof Kozlowski
2024-04-22 16:02 ` Andrew Lunn
2024-04-22 8:46 ` [PATCH 2/3] arm64: dts: imx93: add enet_clk_sel Steffen Trumtrar
2024-04-22 8:46 ` [PATCH 3/3] net: stmicro: imx: set TX_CLK direction in RMII mode Steffen Trumtrar
2024-04-22 8:51 ` Ahmad Fatoum
2024-04-22 9:04 ` Marc Kleine-Budde
2024-04-22 9:12 ` Krzysztof Kozlowski
2024-04-22 9:28 ` Sébastien Szymanski [this message]
2024-04-23 6:43 ` [PATCH 0/3] arm64: mx93: etherrnet: set TX_CLK " Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f01d49cf-5955-405c-9c2b-05b0c7bb982c@armadeus.com \
--to=sebastien.szymanski@armadeus.com \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s.trumtrar@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox