Re: [PATCH v6 9/9] irqchip/imx-irqsteer: Use devm_irq_domain_create_linear()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] core: code and commit message mismatch regarding old domain API
--

commit 05a4c59bf91334e37803afcd72a82640aa12007b
Author: Zhipeng Wang <zhipeng.wang_1@nxp.com>

irqchip/imx-irqsteer: Use devm_irq_domain_create_linear()

This commit updates the imx-irqsteer driver to use the device-managed
devm_irq_domain_create_linear() function for creating the IRQ domain. It
also removes the manual domain removal code in the driver's remove path.

> The driver open-codes an irq_domain_info and calls
> devm_irq_domain_instantiate() only to get a linear revmap domain tied to
> the device lifetime. Use the new devm_irq_domain_create_linear() helper
> instead. No functional change.

[Severity: Medium]
Does this commit message accurately describe the previous state of the code?

The commit message states that the driver open-codes an irq_domain_info and
calls devm_irq_domain_instantiate(). However, the diff shows the driver was
actually using irq_domain_create_linear() in imx_irqsteer_probe() and
tearing it down manually with irq_domain_remove() in imx_irqsteer_remove().

Could the commit message have been copied from another patch in the series?

> diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c
> index 85edd5e33ca9c..f5601769d0363 100644
> --- a/drivers/irqchip/irq-imx-irqsteer.c
> +++ b/drivers/irqchip/irq-imx-irqsteer.c
> @@ -246,8 +246,9 @@ static int imx_irqsteer_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> -	data->domain = irq_domain_create_linear(dev_fwnode(&pdev->dev), data->reg_num * 32,
> -						&imx_irqsteer_domain_ops, data);
> +	data->domain = devm_irq_domain_create_linear(&pdev->dev, dev_fwnode(&pdev->dev),
> +						     data->reg_num * 32,
> +						     &imx_irqsteer_domain_ops, data);

[ ... ]

> @@ -294,8 +295,6 @@ static void imx_irqsteer_remove(struct platform_device *pdev)
>  		irq_dispose_mapping(irqsteer_data->irq[i]);
>  	}
>  
> -	irq_domain_remove(irqsteer_data->domain);
> -
>  	if (ret >= 0)
>  		pm_runtime_put_noidle(&pdev->dev);
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008090231.796511-1-Zhipeng.wang_1@oss.nxp.com?part=9