Re: [PATCH v2 1/5] dt-bindings: firmware: imx: Add SCU controlled display pixel link nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: firmware: fsl,scu: enforces non-generic child node names
--

commit bc38a98038b8a49cd066c13a1783d4225b66e234
Author: Liu Ying <victor.liu@nxp.com>

dt-bindings: firmware: imx: Add SCU controlled display pixel link nodes

This commit documents the SCU controlled display pixel link child nodes 
in the fsl,scu firmware binding.

> diff --git a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> index 307f1c6278532..cd6cda1192a89 100644
> --- a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> +++ b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> @@ -30,6 +30,26 @@ properties:
>        Clock controller node that provides the clocks controlled by the SCU
>      $ref: /schemas/clock/fsl,scu-clk.yaml
>  
> +  dc0-pixel-link0:
> +    description:
> +      Display pixel link0 in display controller subsystem0 controlled by the SCU
> +    $ref: /schemas/display/bridge/fsl,imx8qxp-pixel-link.yaml

[Severity: Low]
Does this naming scheme violate the Devicetree Specification Section 2.2
(Generic Names Recommendation)?

The specification recommends that node names reflect the general function
of the device and avoid hardware-specific programming models or block indices.
Enforcing exact node names like dc0-pixel-link0 prevents device tree sources
from using generic names.

Looking at the SCU firmware driver in drivers/firmware/imx/imx-scu.c, child
nodes are populated using devm_of_platform_populate(), and the downstream
bridge driver in drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c binds using
the compatible string (fsl,imx8qxp-dc-pixel-link), not the node name. 

Since there is no driver or firmware ABI requirement dictating these fixed
node names, would it be better to use patternProperties, for example
^pixel-link(-[0-9]+)?$, to allow and validate generic naming?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014071657.118378-1-alexander.stein@ew.tq-group.com?part=1