[PATCH] arm64: dts: freescale: lx2160a-nbxv3: fix 1588 and id line names

[PATCH] arm64: dts: freescale: lx2160a-nbxv3: fix 1588 and id line names

[Vincent Jardin via B4 Relay]

From: Vincent Jardin <vjardin@free.fr>

Let's properly support 1588 on this board and fix the names.

Fixes: 565b6713a460 ("arm64: dts: freescale: add Nodebox v3 CPU Module")
Signed-off-by: Vincent Jardin <vjardin@free.fr>
---
 .../boot/dts/freescale/fsl-lx2160a-nbxv3.dtsi      | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-nbxv3.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-nbxv3.dtsi
index 9c5588a75cdd..5591ae262707 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-nbxv3.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-nbxv3.dtsi
@@ -169,7 +169,6 @@ &gpio1 {
 
 	status = "okay";
 
-	/* Platform reset, no consumer node: released at boot */
 	pltrst-hog {
 		gpio-hog;
 		gpios = <29 GPIO_ACTIVE_LOW>;
@@ -206,9 +205,9 @@ &gpio3 {
 		"altfn:ec1-rxd1", "altfn:ec1-rxd0",
 		"altfn:ec1-rx-clk", "altfn:ec1-rx-dv",
 		"", "",
-		"ptp-refclk-in",
+		"altfn:tsec1588-clk-out",
 		"", "", "", "", "", "", "", "",
-		"u1700-zl30733-pps-out",
+		"altfn:tsec1588-trig-in1",
 		"",
 		"ethsw-mdio-en",
 		"usb1-oc#",	/* USB1_PWRFAULT and USB2_PWRFAULT pads: one wired-OR net */
@@ -247,21 +246,20 @@ eeprom@52 {
 		pagesize = <32>;
 	};
 
-	/* Board ID straps */
 	gpio@74 {
 		compatible = "ti,tca9539";
 		reg = <0x74>;
 		#gpio-cells = <2>;
 		gpio-controller;
 		gpio-line-names =
-			"boardid-0x0001", "boardid-0x0002",
-			"boardid-0x0004", "boardid-0x0008",
-			"boardid-0x0010", "boardid-0x0020",
-			"boardid-0x0040", "boardid-0x0080",
-			"boardid-0x0100", "boardid-0x0200",
-			"boardid-0x0400", "boardid-0x0800",
-			"boardid-0x1000", "boardid-0x2000",
-			"boardid-0x4000", "boardid-0x8000";
+			"boardid-0x01", "boardid-0x02",
+			"boardid-0x04", "boardid-0x08",
+			"boardid-0x10", "boardid-0x20",
+			"boardid-0x40", "boardid-0x80",
+			"test-mode-tp1500",
+			"gnd-p11", "gnd-p12", "gnd-p13",
+			"gnd-p14", "gnd-p15", "gnd-p16",
+			"gnd-p17";
 	};
 
 	u800: gpio@75 {

---
base-commit: cbbddb6b08cc9900a87cccaa9b22bbe06aa4f50a
change-id: 20261101-for-upstream-nbxv3-dts-line-names-93b121a5b440

Best regards,
-- 
Vincent Jardin <vjardin@free.fr>

Re: [PATCH] arm64: dts: freescale: lx2160a-nbxv3: fix 1588 and id line names

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] arm64: dts: freescale: incomplete changelog and unexplained changes
--

commit 2208a7074ab4d2a50b39680ab1785ee7073ca209
Author: Vincent Jardin <vjardin@free.fr>

arm64: dts: freescale: lx2160a-nbxv3: fix 1588 and id line names

This commit updates gpio-line-names in gpio3 and gpio@74 in
fsl-lx2160a-nbxv3.dtsi and removes comments above pltrst-hog and gpio@74.

>     arm64: dts: freescale: lx2160a-nbxv3: fix 1588 and id line names
>
>     Let's properly support 1588 on this board and fix the names.
>
>     Fixes: 565b6713a460 ("arm64: dts: freescale: add Nodebox v3 CPU Module")
>     Signed-off-by: Vincent Jardin <vjardin@free.fr>
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-nbxv3.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-nbxv3.dtsi
> index 9c5588a75cdd4..5591ae262707c 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-nbxv3.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-nbxv3.dtsi
> @@ -169,7 +169,6 @@ &gpio1 {
>  
>  	status = "okay";
>  
> -	/* Platform reset, no consumer node: released at boot */
>  	pltrst-hog {
>  		gpio-hog;
>  		gpios = <29 GPIO_ACTIVE_LOW>;
> @@ -206,9 +205,9 @@ &gpio3 {
>  		"altfn:ec1-rxd1", "altfn:ec1-rxd0",
>  		"altfn:ec1-rx-clk", "altfn:ec1-rx-dv",
>  		"", "",
> -		"ptp-refclk-in",
> +		"altfn:tsec1588-clk-out",
>  		"", "", "", "", "", "", "", "",
> -		"u1700-zl30733-pps-out",
> +		"altfn:tsec1588-trig-in1",
>  		"",
>  		"ethsw-mdio-en",
>  		"usb1-oc#",	/* USB1_PWRFAULT and USB2_PWRFAULT pads: one wired-OR net */
> @@ -247,21 +246,20 @@ eeprom@52 {
>  		pagesize = <32>;
>  	};
>  
> -	/* Board ID straps */
>  	gpio@74 {
>  		compatible = "ti,tca9539";
>  		reg = <0x74>;
>  		#gpio-cells = <2>;
>  		gpio-controller;
>  		gpio-line-names =
> -			"boardid-0x0001", "boardid-0x0002",
> -			"boardid-0x0004", "boardid-0x0008",
> -			"boardid-0x0010", "boardid-0x0020",
> -			"boardid-0x0040", "boardid-0x0080",
> -			"boardid-0x0100", "boardid-0x0200",
> -			"boardid-0x0400", "boardid-0x0800",
> -			"boardid-0x1000", "boardid-0x2000",
> -			"boardid-0x4000", "boardid-0x8000";
> +			"boardid-0x01", "boardid-0x02",
> +			"boardid-0x04", "boardid-0x08",
> +			"boardid-0x10", "boardid-0x20",
> +			"boardid-0x40", "boardid-0x80",
> +			"test-mode-tp1500",
> +			"gnd-p11", "gnd-p12", "gnd-p13",
> +			"gnd-p14", "gnd-p15", "gnd-p16",
> +			"gnd-p17";
>  	};

[Severity: Low]
This isn't a bug, but could the commit message be expanded to accurately
describe these changes and their rationale?

First, the commit message states "Let's properly support 1588 on this board
and fix the names", whereas the patch only updates informational
gpio-line-names strings in gpio3 from ptp-refclk-in and u1700-zl30733-pps-out
to altfn:tsec1588-clk-out and altfn:tsec1588-trig-in1 without configuring
clocks, pinmux, or 1588 hardware nodes.

Second, the changelog does not explain why those gpio3 entries are relabeled
with the altfn: prefix (for instance, whether the RCW muxes those pads to
TSEC 1588 alternate functions rather than GPIOs), or why the TCA9539
expander at gpio@74 is changed from 16 board ID straps (boardid-0x0001
through boardid-0x8000) to an 8-bit board ID (boardid-0x01 through
boardid-0x80) plus test-mode-tp1500 and grounded pins gnd-p11 through
gnd-p17.

Finally, was removing the comment above pltrst-hog in gpio1 intentional, as
it appears unrelated to 1588 or board ID line names?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261101-for-upstream-nbxv3-dts-line-names-v1-1-7c8eecb2da9f@free.fr?part=1

Re: [PATCH] arm64: dts: freescale: lx2160a-nbxv3: fix 1588 and id line names

[Vincent Jardin]

Hi M. Bot,

> First, the commit message states "Let's properly support 1588 on this board
> and fix the names", whereas the patch only updates informational
> gpio-line-names strings in gpio3 from ptp-refclk-in and u1700-zl30733-pps-out
> to altfn:tsec1588-clk-out and altfn:tsec1588-trig-in1 without configuring
> clocks, pinmux, or 1588 hardware nodes.

the 1588 is already into the lx2160's dtsi (see boot/dts/freescale/ ptp-timer@8b95000,
for its fsl,dpaa2-ptp). The CPU pads are muxes at processor reset by its RCW,
so this patch only fixes names. I'll improve v2 accordingly.

> Second, the changelog does not explain why those gpio3 entries are relabeled
> with the altfn: prefix (for instance, whether the RCW muxes those pads to
> TSEC 1588 alternate functions rather than GPIOs), or why the TCA9539
> expander at gpio@74 is changed from 16 board ID straps (boardid-0x0001
> through boardid-0x8000) to an 8-bit board ID (boardid-0x01 through
> boardid-0x80) plus test-mode-tp1500 and grounded pins gnd-p11 through
> gnd-p17.

Few topics:

For timing,
On this board, the CPU's RCW sets EC2_PMUX = 0b10,
so GPIO4[14] and GPIO4[23] are resp. TSEC_1588_CLK_OUT and TSEC_1588_TRIG_IN1
but not GPIOs.
altfn: is the prefix the dtsi already uses for such cases.
The new proposed names avoid the confusions between the DPLL's pins the CPU
is connected with vs the real local CPU/lx2160's pad the CPU is assigned by
its mux.

For board ID, the schematic is based on 8 bits with P00..P07, for the initial
commit I did over interpret. P10 is not a board ID

> Finally, was removing the comment above pltrst-hog in gpio1 intentional, as
> it appears unrelated to 1588 or board ID line names?

No, it is not related.

best regards,
  Vincent

> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20261101-for-upstream-nbxv3-dts-line-names-v1-1-7c8eecb2da9f@free.fr?part=1
>