Old style <server-ip>:/<path> not handled

Old style <server-ip>:/<path> not handled

[Warren Togami]

> # This script is sourced, so root should be set. But let's be paranoid
> [ -z "$root" ] && root=$(getarg root=)
> [ -z "$netroot" ] && netroot=$(getarg netroot=)
> [ -z "$nfsroot" ] && nfsroot=$(getarg nfsroot=)
>
> # Handle old style <server-ip>:/<path
> case "$netroot" in
>     [0-9]*:/*|[0-9]*\.[0-9]*\.[0-9]*[!:]|/*)
>        netroot=nfs:$netroot;;
> esac

By the current code it seems the old style root=<server-ip>:/<path> is 
not actually handled.

I'm soon pushing a patch that restricts NFS to only root= which should 
fix this and eliminate the redundant root= and netroot= test cases.

Warren Togami
wtogami-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Old style <server-ip>:/<path> not handled

[Seewer Philippe]

Warren Togami wrote:
>> # This script is sourced, so root should be set. But let's be paranoid
>> [ -z "$root" ] && root=$(getarg root=)
>> [ -z "$netroot" ] && netroot=$(getarg netroot=)
>> [ -z "$nfsroot" ] && nfsroot=$(getarg nfsroot=)
>>
>> # Handle old style <server-ip>:/<path
>> case "$netroot" in
>>     [0-9]*:/*|[0-9]*\.[0-9]*\.[0-9]*[!:]|/*)
>>        netroot=nfs:$netroot;;
>> esac
> 
> By the current code it seems the old style root=<server-ip>:/<path> is 
> not actually handled.

The current code only handles netroot=<oldstyle>. This works for cmdline 
or if <oldstyle> is delivered by dhcp root-path. I think that was 
haralds intention anyway.

> I'm soon pushing a patch that restricts NFS to only root= which should 
> fix this and eliminate the redundant root= and netroot= test cases.
> 
> Warren Togami
> wtogami-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
> -- 
> To unsubscribe from this list: send the line "unsubscribe initramfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html