[PATCH] Don't use absolute paths for utilities

[PATCH] Don't use absolute paths for utilities

[Seewer Philippe]

diff --git a/dracut b/dracut
index 826fbda..1d440ef 100755
--- a/dracut
+++ b/dracut
@@ -61,6 +61,8 @@ while (($# > 0)); do
     shift
 done
 
+PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:$PATH
+
 [[ $debug ]] && { 
     export PS4='${BASH_SOURCE}@${LINENO}(${FUNCNAME[0]}): ';
     set -x
@@ -138,8 +140,8 @@ echo $mods_to_load
 ## final stuff that has to happen
 
 # generate module dependencies for the initrd
-if ! /sbin/depmod -a -b "$initdir" $kernel; then
-    echo "\"/sbin/depmod -a $kernel\" failed."
+if ! depmod -a -b "$initdir" $kernel; then
+    echo "\"depmod -a $kernel\" failed."
     exit 1
 fi
 
diff --git a/dracut-functions b/dracut-functions
index 8fbfa97..e525179 100755
--- a/dracut-functions
+++ b/dracut-functions
@@ -307,7 +307,7 @@ instmods() {
 		    fi
 		    inst_simple "$modpath"
 		done
-		for fw in $(/sbin/modinfo -F firmware $mod 2>/dev/null); do
+		for fw in $(modinfo -F firmware $mod 2>/dev/null); do
 		    if [[ -f /lib/firmware/$fw ]]; then
 			inst_simple "/lib/firmware/$fw"
 		    else
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Don't use absolute paths for utilities

[David Dillow]

On Thu, 2009-07-02 at 16:03 +0200, Seewer Philippe wrote:
> diff --git a/dracut b/dracut

It would be good if your commit message mentioned why it is not a good
idea to use absolute paths, eg different distros put things in different
places, etc.
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Don't use absolute paths for utilities

[Seewer Philippe]

David Dillow wrote:
> On Thu, 2009-07-02 at 16:03 +0200, Seewer Philippe wrote:
>> diff --git a/dracut b/dracut
> 
> It would be good if your commit message mentioned why it is not a good
> idea to use absolute paths, eg different distros put things in different
> places, etc.

We've had the discussion about absolute paths and distros a few times, 
so it should be obvious.
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Don't use absolute paths for utilities

[David Dillow]

On Thu, 2009-07-02 at 16:40 +0200, Seewer Philippe wrote:
> 
> David Dillow wrote:
> > On Thu, 2009-07-02 at 16:03 +0200, Seewer Philippe wrote:
> >> diff --git a/dracut b/dracut
> > 
> > It would be good if your commit message mentioned why it is not a good
> > idea to use absolute paths, eg different distros put things in different
> > places, etc.
> 
> We've had the discussion about absolute paths and distros a few times, 
> so it should be obvious.

We have, on the list and in IRC, but newcomers to the project will only
have the commit log. Our commit text has often been of the same quality
as
	int i = 0; /* set i to zero */

and I'd like to see it improve. This isn't directed solely at you --
many of us are guilty, including myself.

--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Don't use absolute paths for utilities

[Harald Hoyer]

On 07/02/2009 04:03 PM, Seewer Philippe wrote:
> diff --git a/dracut b/dracut
> index 826fbda..1d440ef 100755
> --- a/dracut
> +++ b/dracut
> @@ -61,6 +61,8 @@ while (($# > 0)); do
> shift
> done
>
> +PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:$PATH
> +
> [[ $debug ]] && { export PS4='${BASH_SOURCE}@${LINENO}(${FUNCNAME[0]}): ';
> set -x
> @@ -138,8 +140,8 @@ echo $mods_to_load
> ## final stuff that has to happen
>
> # generate module dependencies for the initrd
> -if ! /sbin/depmod -a -b "$initdir" $kernel; then
> - echo "\"/sbin/depmod -a $kernel\" failed."
> +if ! depmod -a -b "$initdir" $kernel; then
> + echo "\"depmod -a $kernel\" failed."
> exit 1
> fi
>
> diff --git a/dracut-functions b/dracut-functions
> index 8fbfa97..e525179 100755
> --- a/dracut-functions
> +++ b/dracut-functions
> @@ -307,7 +307,7 @@ instmods() {
> fi
> inst_simple "$modpath"
> done
> - for fw in $(/sbin/modinfo -F firmware $mod 2>/dev/null); do
> + for fw in $(modinfo -F firmware $mod 2>/dev/null); do
> if [[ -f /lib/firmware/$fw ]]; then
> inst_simple "/lib/firmware/$fw"
> else

pushed
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html