From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Sergey Fionov <fionov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] Fix full pathname condition in find_library
Date: Wed, 05 Aug 2009 16:22:55 +0200 [thread overview]
Message-ID: <4A7995BF.10801@redhat.com> (raw)
In-Reply-To: <op.uxy35cntfzkdih@etgc>
On 08/01/2009 09:52 AM, Sergey Fionov wrote:
> Hello,
>
> Now a fact that the path is full is checked by
> [[ -x $1 ]]
>
> But if the working directory is /bin or a directory with a file named
> "mount",
> this condition will be met for "inst mount", and "mount" will not be copied
> into initrd at all.
>
> diff --git a/dracut-functions b/dracut-functions
> index d4caacf..1078bfd 100755
> --- a/dracut-functions
> +++ b/dracut-functions
> @@ -83,7 +83,7 @@ inst_library() {
> # search in the usual places to find the binary.
> find_binary() {
> local binpath="/bin /sbin /usr/bin /usr/sbin" p
> - [[ -x $1 ]] && { echo $1; return 0; }
> + [[ -z ${1##/*} && -x $1 ]] && { echo $1; return 0; }
> for p in $binpath; do
> [[ -x $p/$1 ]] && { echo "$p/$1"; return 0; }
> done
merged in git
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-08-05 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-01 7:52 [PATCH] Fix full pathname condition in find_library Sergey Fionov
2009-08-05 14:22 ` Harald Hoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A7995BF.10801@redhat.com \
--to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=fionov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox