mkinitrd unification across distributions
 help / color / mirror / Atom feed
From: "Sergey Fionov" <fionov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] Fix full pathname condition in find_library
Date: Sat, 01 Aug 2009 11:52:16 +0400	[thread overview]
Message-ID: <op.uxy35cntfzkdih@etgc> (raw)

Hello,

Now a fact that the path is full is checked by
[[ -x $1 ]]

But if the working directory is /bin or a directory with a file named  
"mount",
this condition will be met for "inst mount", and "mount" will not be copied
into initrd at all.

diff --git a/dracut-functions b/dracut-functions
index d4caacf..1078bfd 100755
--- a/dracut-functions
+++ b/dracut-functions
@@ -83,7 +83,7 @@ inst_library() {
  # search in the usual places to find the binary.
  find_binary() {
      local binpath="/bin /sbin /usr/bin /usr/sbin" p
-    [[ -x $1 ]] && { echo $1; return 0; }
+    [[ -z ${1##/*} && -x $1 ]] && { echo $1; return 0; }
      for p in $binpath; do
         [[ -x $p/$1 ]] && { echo "$p/$1"; return 0; }
      done
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2009-08-01  7:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-01  7:52 Sergey Fionov [this message]
2009-08-05 14:22 ` [PATCH] Fix full pathname condition in find_library Harald Hoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.uxy35cntfzkdih@etgc \
    --to=fionov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox