[PATCH] Run plymouth only if on a normal console

[PATCH] Run plymouth only if on a normal console

[Andreas Thienemann]

Run plymouth only when running on a normal console. When the machine is 
using a serial console or braille terminal etc. do not start plymouth.

That will give people the ability to type in crypto passphrases etc. on a 
serial terminal.

---
 modules.d/50plymouth/plymouth-pretrigger.sh |   13 ++++++++++++-
 1 files changed, 12 insertions(+), 1 deletions(-)

diff --git a/modules.d/50plymouth/plymouth-pretrigger.sh b/modules.d/50plymouth/plymouth-pretrigger.sh
index 25ed06f..d3c8a2a 100755
--- a/modules.d/50plymouth/plymouth-pretrigger.sh
+++ b/modules.d/50plymouth/plymouth-pretrigger.sh
@@ -2,7 +2,18 @@
 # -*- mode: shell-script; indent-tabs-mode: nil; sh-basic-offset: 4; -*-
 # ex: ts=8 sw=4 sts=4 et filetype=sh
 
-if getargbool 1 rd.plymouth -n rd_NO_PLYMOUTH; then
+# Check for normal console
+is_normal_console() {
+    for con in $(getargs console); do
+        case $con in
+            tty[0..9]) continue;;
+            *) return 1;;
+        esac
+    done
+    return 0
+}
+
+if getargbool 1 rd.plymouth -n rd_NO_PLYMOUTH && is_normal_console; then
     [ -c /dev/null ] || mknod -m 0666 /dev/null c 1 3
     # first trigger graphics subsystem
     udevadm trigger --action=add --attr-match=class=0x030000 >/dev/null 2>&1
-- 
1.7.4.4

Re: [PATCH] Run plymouth only if on a normal console

[Harald Hoyer]

Am 25.05.2011 12:26, schrieb Andreas Thienemann:
>
> Run plymouth only when running on a normal console. When the machine is
> using a serial console or braille terminal etc. do not start plymouth.
>
> That will give people the ability to type in crypto passphrases etc. on a
> serial terminal.
>
> ---
>   modules.d/50plymouth/plymouth-pretrigger.sh |   13 ++++++++++++-
>   1 files changed, 12 insertions(+), 1 deletions(-)
>
> diff --git a/modules.d/50plymouth/plymouth-pretrigger.sh b/modules.d/50plymouth/plymouth-pretrigger.sh
> index 25ed06f..d3c8a2a 100755
> --- a/modules.d/50plymouth/plymouth-pretrigger.sh
> +++ b/modules.d/50plymouth/plymouth-pretrigger.sh
> @@ -2,7 +2,18 @@
>   # -*- mode: shell-script; indent-tabs-mode: nil; sh -basic-offset: 4; -*-
>   # ex: ts=8 sw=4 sts=4 et filetype=sh
>
> -if getargbool 1 rd.plymouth -n rd_NO_PLYMOUTH; then
> +# Check for normal console
> +is_normal_console() {
> +    for con in $(getargs console); do
> +        case $con in
> +            tty[0..9]) continue;;
> +            *) return 1;;
> +        esac
> +    done
> +    return 0
> +}
> +
> +if getargbool 1 rd.plymouth -n rd_NO_PLYMOUTH&&  is_normal_console; then
>       [ -c /dev/null ] || mknod -m 0666 /dev/null c 1 3
>       # first trigger graphics subsystem
>       udevadm trigger --action=add --attr-match=class=0x030000>/dev/null 2>&1


Does it also work if you check /sys/class/tty/console/active for tty0 
instead?