mkinitrd unification across distributions
 help / color / mirror / Atom feed
* [PATCH] crypt: dropped plymouth --has-active-vt check on passwd prompt
@ 2011-06-30 21:49 Amadeusz Żołnowski
       [not found] ` <1309470560-16173-1-git-send-email-aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Amadeusz Żołnowski @ 2011-06-30 21:49 UTC (permalink / raw)
  To: initramfs-u79uwXL29TY76Z2rM5mHXA; +Cc: Amadeusz Żołnowski

As Ray Strode explains, plymouth --has-active-vt may fail if the user
passes console=ttyS0 or something other not corresponding to
console=tty0, because plymouth is outputing to the serial console and
not a VT in this case.
---
 modules.d/90crypt/crypt-lib.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules.d/90crypt/crypt-lib.sh b/modules.d/90crypt/crypt-lib.sh
index 122d88e..3ef8482 100644
--- a/modules.d/90crypt/crypt-lib.sh
+++ b/modules.d/90crypt/crypt-lib.sh
@@ -47,7 +47,7 @@ ask_for_password() {
 
     { flock -s 9;
         # Prompt for password with plymouth, if installed and running.
-        if [ -x /bin/plymouth ] && /bin/plymouth --has-active-vt; then
+        if [ -x /bin/plymouth ]; then
             /bin/plymouth ask-for-password \
                 --prompt "$ply_prompt" --number-of-tries=$ply_tries \
                 --command="$ply_cmd"
-- 
1.7.5.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] crypt: dropped plymouth --has-active-vt check on passwd prompt
       [not found] ` <1309470560-16173-1-git-send-email-aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org>
@ 2011-08-12  6:21   ` Harald Hoyer
  0 siblings, 0 replies; 2+ messages in thread
From: Harald Hoyer @ 2011-08-12  6:21 UTC (permalink / raw)
  To: Amadeusz Żołnowski; +Cc: initramfs-u79uwXL29TY76Z2rM5mHXA

On 30.06.2011 23:49, Amadeusz Żołnowski wrote:
> As Ray Strode explains, plymouth --has-active-vt may fail if the user
> passes console=ttyS0 or something other not corresponding to
> console=tty0, because plymouth is outputing to the serial console and
> not a VT in this case.
> ---
>  modules.d/90crypt/crypt-lib.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/modules.d/90crypt/crypt-lib.sh b/modules.d/90crypt/crypt-lib.sh
> index 122d88e..3ef8482 100644
> --- a/modules.d/90crypt/crypt-lib.sh
> +++ b/modules.d/90crypt/crypt-lib.sh
> @@ -47,7 +47,7 @@ ask_for_password() {
>  
>      { flock -s 9;
>          # Prompt for password with plymouth, if installed and running.
> -        if [ -x /bin/plymouth ] && /bin/plymouth --has-active-vt; then
> +        if [ -x /bin/plymouth ]; then
>              /bin/plymouth ask-for-password \
>                  --prompt "$ply_prompt" --number-of-tries=$ply_tries \
>                  --command="$ply_cmd"

pushed

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-12  6:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-30 21:49 [PATCH] crypt: dropped plymouth --has-active-vt check on passwd prompt Amadeusz Żołnowski
     [not found] ` <1309470560-16173-1-git-send-email-aidecoe-2qtfh70TtYba5EbDDlwbIw@public.gmane.org>
2011-08-12  6:21   ` Harald Hoyer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox