From: John Reiser <jreiser-Po6cBsTGB2ZWk0Htik3J/w@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] Fail to boot if mediacheck fails (#817419)
Date: Thu, 10 May 2012 07:23:46 -0700 [thread overview]
Message-ID: <4FABCF72.4020209@bitwagon.com> (raw)
In-Reply-To: <4FAB8966.70600-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On 05/10/2012 02:24 AM, Harald Hoyer wrote:
> Am 09.05.2012 20:15, schrieb Brian C. Lane:
>> The return value of checkisomd5 was being ignored.
>> - checkisomd5 --verbose $livedev || :
>> + checkisomd5 --verbose $livedev
> So, it was wrong from the beginning on... rofl..
And the "fix" is still not the best. There should be an _option_
to "perform the check, but ignore the result". The user may want
to try booting anyway. implantisomd5 generates separate checksums
for 20 separate areas. If checkisomd5 indicates that exactly one
area is bad, and it is number 19 of 20 [from the beginning],
then continuing to boot may be a very reasonable choice.
--
prev parent reply other threads:[~2012-05-10 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 18:15 [PATCH] Fail to boot if mediacheck fails (#817419) Brian C. Lane
[not found] ` <1336587303-3778-1-git-send-email-bcl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-10 9:24 ` Harald Hoyer
[not found] ` <4FAB8966.70600-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-05-10 14:23 ` John Reiser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FABCF72.4020209@bitwagon.com \
--to=jreiser-po6cbstgb2zwk0htik3j/w@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox