[PATCH] Fail to boot if mediacheck fails (#817419)

[PATCH] Fail to boot if mediacheck fails (#817419)

[Brian C. Lane]

From: "Brian C. Lane" <bcl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

The return value of checkisomd5 was being ignored.
---
 modules.d/90dmsquash-live/dmsquash-live-root.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/modules.d/90dmsquash-live/dmsquash-live-root.sh b/modules.d/90dmsquash-live/dmsquash-live-root.sh
index 2aaec28..fdbd6f5 100755
--- a/modules.d/90dmsquash-live/dmsquash-live-root.sh
+++ b/modules.d/90dmsquash-live/dmsquash-live-root.sh
@@ -33,7 +33,7 @@ fi
 getarg rd.live.check check || check=""
 if [ -n "$check" ]; then
     [ -x /bin/plymouth ] && /bin/plymouth --hide-splash
-    checkisomd5 --verbose $livedev || :
+    checkisomd5 --verbose $livedev
     if [ $? -ne 0 ]; then
         die "CD check failed!"
         exit 1
-- 
1.7.7.6

Re: [PATCH] Fail to boot if mediacheck fails (#817419)

[Harald Hoyer]

Am 09.05.2012 20:15, schrieb Brian C. Lane:
> From: "Brian C. Lane" <bcl-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> 
> The return value of checkisomd5 was being ignored.
> ---
>  modules.d/90dmsquash-live/dmsquash-live-root.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/modules.d/90dmsquash-live/dmsquash-live-root.sh b/modules.d/90dmsquash-live/dmsquash-live-root.sh
> index 2aaec28..fdbd6f5 100755
> --- a/modules.d/90dmsquash-live/dmsquash-live-root.sh
> +++ b/modules.d/90dmsquash-live/dmsquash-live-root.sh
> @@ -33,7 +33,7 @@ fi
>  getarg rd.live.check check || check=""
>  if [ -n "$check" ]; then
>      [ -x /bin/plymouth ] && /bin/plymouth --hide-splash
> -    checkisomd5 --verbose $livedev || :
> +    checkisomd5 --verbose $livedev
>      if [ $? -ne 0 ]; then
>          die "CD check failed!"
>          exit 1


So, it was wrong from the beginning on... rofl..


commit c56b63d1bd06e3eaf149502d7c46c59a5978fd44
Author: Jeremy Katz <katzj-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Date:   Wed Jul 22 16:06:29 2009 -0400

    Support checking the iso

    Support checking the iso image with checkisomd5 if available

Re: [PATCH] Fail to boot if mediacheck fails (#817419)

[John Reiser]

On 05/10/2012 02:24 AM, Harald Hoyer wrote:
> Am 09.05.2012 20:15, schrieb Brian C. Lane:

>> The return value of checkisomd5 was being ignored.

>> -    checkisomd5 --verbose $livedev || :
>> +    checkisomd5 --verbose $livedev

> So, it was wrong from the beginning on... rofl..

And the "fix" is still not the best.  There should be an _option_
to "perform the check, but ignore the result".  The user may want
to try booting anyway.  implantisomd5 generates separate checksums
for 20 separate areas.  If checkisomd5 indicates that exactly one
area is bad, and it is number 19 of 20 [from the beginning],
then continuing to boot may be a very reasonable choice.

--