* Re: [dracut] weird code in dracut-logger.sh
[not found] ` <20120922161129.GA952-oV2J+Z9pNWCehbqAyNb4It9vCcoqechNLybGJaePZcc@public.gmane.org>
@ 2012-09-24 1:48 ` Dave Young
0 siblings, 0 replies; only message in thread
From: Dave Young @ 2012-09-24 1:48 UTC (permalink / raw)
To: Consus, initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Harald Hoyer
Hi,
I'm not sure about this issue. Sending to dracut mainling list.
On 09/23/2012 12:11 AM, Consus wrote:
> Hi,
>
> I want to ask you about some piece of code I found lately in dracut-logger.sh:
>
> 141 || if (( $sysloglvl >= 0 )); then
> 142 || if ! [ -S /dev/log -a -w /dev/log ] || ! command -v logger >/dev/null
> 143 || then
> 144 || # We cannot log to syslog, so turn this facility off.
> 145 || sysloglvl=0
>
> I may be wrong, but this should be changed to (( $sysloglvl > 0 )). For
> now this code causes error messages even if this facility is disabled.
> For example, with fileloglvl=0 I'm getting
>
> /usr/lib/dracut/dracut-logger.sh: line 122: : No such file or directory
>
> on every dracut run (with -1 works fine). So I suggest either adding -1
> as "facility disabled" to documentation or rewriting these checks.
>
--
Thanks
Dave
^ permalink raw reply [flat|nested] only message in thread