mkinitrd unification across distributions
 help / color / mirror / Atom feed
* [patch dracut v2] fix teamd exec in case config does not include devname
@ 2013-01-10 14:02 Jiri Pirko
       [not found] ` <1357826571-1877-1-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Jiri Pirko @ 2013-01-10 14:02 UTC (permalink / raw)
  To: initramfs-u79uwXL29TY76Z2rM5mHXA
  Cc: harald-H+wXaHxf7aLQT0dZR+AlfA, amwang-H+wXaHxf7aLQT0dZR+AlfA,
	dyoung-H+wXaHxf7aLQT0dZR+AlfA

In case that configuration file did not include name of team device,
teamd would not start. Fix this by adding "-t" parameter.

Signed-off-by: Jiri Pirko <jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
---

v2->v1:
-fixed bad order of args
	
modules.d/40network/ifup.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules.d/40network/ifup.sh b/modules.d/40network/ifup.sh
index 216b1e3..6c3133e 100755
--- a/modules.d/40network/ifup.sh
+++ b/modules.d/40network/ifup.sh
@@ -187,7 +187,7 @@ if [ -e /tmp/team.info ]; then
             fi
         done
         # Do not add slaves now
-        teamd -d -U -n -f /etc/teamd/$teammaster.conf
+        teamd -d -U -n -t $teammaster -f /etc/teamd/$teammaster.conf
         for slave in $working_slaves; do
             # team requires the slaves to be down before joining team
             ip link set $slave down
-- 
1.8.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [patch dracut v2] fix teamd exec in case config does not include devname
       [not found] ` <1357826571-1877-1-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
@ 2013-01-10 14:10   ` Cong Wang
  2013-01-22 14:35   ` Harald Hoyer
  1 sibling, 0 replies; 3+ messages in thread
From: Cong Wang @ 2013-01-10 14:10 UTC (permalink / raw)
  To: Jiri Pirko
  Cc: initramfs-u79uwXL29TY76Z2rM5mHXA, harald-H+wXaHxf7aLQT0dZR+AlfA,
	dyoung-H+wXaHxf7aLQT0dZR+AlfA

On Thu, 2013-01-10 at 15:02 +0100, Jiri Pirko wrote:
> In case that configuration file did not include name of team device,
> teamd would not start. Fix this by adding "-t" parameter.
> 
> Signed-off-by: Jiri Pirko <jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
> ---
> 
> v2->v1:
> -fixed bad order of args

Looks good! I didn't test the ifcfg case.

Acked-by: Cong Wang <amwang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch dracut v2] fix teamd exec in case config does not include devname
       [not found] ` <1357826571-1877-1-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
  2013-01-10 14:10   ` Cong Wang
@ 2013-01-22 14:35   ` Harald Hoyer
  1 sibling, 0 replies; 3+ messages in thread
From: Harald Hoyer @ 2013-01-22 14:35 UTC (permalink / raw)
  To: Jiri Pirko
  Cc: initramfs-u79uwXL29TY76Z2rM5mHXA, amwang-H+wXaHxf7aLQT0dZR+AlfA,
	dyoung-H+wXaHxf7aLQT0dZR+AlfA

Am 10.01.2013 15:02, schrieb Jiri Pirko:
> In case that configuration file did not include name of team device,
> teamd would not start. Fix this by adding "-t" parameter.
> 
> Signed-off-by: Jiri Pirko <jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
> ---
> 
> v2->v1:
> -fixed bad order of args
> 	
> modules.d/40network/ifup.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules.d/40network/ifup.sh b/modules.d/40network/ifup.sh
> index 216b1e3..6c3133e 100755
> --- a/modules.d/40network/ifup.sh
> +++ b/modules.d/40network/ifup.sh
> @@ -187,7 +187,7 @@ if [ -e /tmp/team.info ]; then
>              fi
>          done
>          # Do not add slaves now
> -        teamd -d -U -n -f /etc/teamd/$teammaster.conf
> +        teamd -d -U -n -t $teammaster -f /etc/teamd/$teammaster.conf
>          for slave in $working_slaves; do
>              # team requires the slaves to be down before joining team
>              ip link set $slave down
> 

merged

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-01-22 14:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-10 14:02 [patch dracut v2] fix teamd exec in case config does not include devname Jiri Pirko
     [not found] ` <1357826571-1877-1-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2013-01-10 14:10   ` Cong Wang
2013-01-22 14:35   ` Harald Hoyer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox