[PATCH] dracut: Do not stop installing drivers if one fails

[PATCH] dracut: Do not stop installing drivers if one fails

[Thomas Renninger]

--add-drivers and --filesystems kernel drivers are added via:
instmods -c
The check option makes the function return if one driver could not get
installed without trying to install further drivers which is bad.

The user is still informed ($_silent is by default no), but all modules
passed to instmods are tried to be loaded, even if one fails.

Signed-off-by: Thomas Renninger <trenn-l3A5Bk7waGM@public.gmane.org>

Index: dracut-037/dracut-functions.sh
===================================================================
--- dracut-037.orig/dracut-functions.sh
+++ dracut-037/dracut-functions.sh
@@ -1689,18 +1689,16 @@ instmods() {
         if (($# == 0)); then  # filenames from stdin
             while read _mod; do
                 inst1mod "${_mod%.ko*}" || {
-                    if [[ "$_check" == "yes" ]]; then
-                        [[ "$_silent" == "no" ]] && dfatal "Failed to install module $_mod"
-                        return 1
+                    if [[ "$_check" == "yes" ]] && [[ "$_silent" == "no" ]]; then
+                        dfatal "Failed to install module $_mod"
                     fi
                 }
             done
         fi
         while (($# > 0)); do  # filenames as arguments
             inst1mod ${1%.ko*} || {
-                if [[ "$_check" == "yes" ]]; then
-                    [[ "$_silent" == "no" ]] && dfatal "Failed to install module $1"
-                    return 1
+                if [[ "$_check" == "yes" ]] && [[ "$_silent" == "no" ]]; then
+                    dfatal "Failed to install module $1"
                 fi
             }
             shift

Re: [PATCH] dracut: Do not stop installing drivers if one fails

[Harald Hoyer]

On 07.05.2014 17:58, Thomas Renninger wrote:
> --add-drivers and --filesystems kernel drivers are added via:
> instmods -c
> The check option makes the function return if one driver could not get
> installed without trying to install further drivers which is bad.
> 
> The user is still informed ($_silent is by default no), but all modules
> passed to instmods are tried to be loaded, even if one fails.
> 
> Signed-off-by: Thomas Renninger <trenn-l3A5Bk7waGM@public.gmane.org>
> 
> Index: dracut-037/dracut-functions.sh
> ===================================================================
> --- dracut-037.orig/dracut-functions.sh
> +++ dracut-037/dracut-functions.sh
> @@ -1689,18 +1689,16 @@ instmods() {
>          if (($# == 0)); then  # filenames from stdin
>              while read _mod; do
>                  inst1mod "${_mod%.ko*}" || {
> -                    if [[ "$_check" == "yes" ]]; then
> -                        [[ "$_silent" == "no" ]] && dfatal "Failed to install module $_mod"
> -                        return 1
> +                    if [[ "$_check" == "yes" ]] && [[ "$_silent" == "no" ]]; then
> +                        dfatal "Failed to install module $_mod"
>                      fi
>                  }
>              done
>          fi
>          while (($# > 0)); do  # filenames as arguments
>              inst1mod ${1%.ko*} || {
> -                if [[ "$_check" == "yes" ]]; then
> -                    [[ "$_silent" == "no" ]] && dfatal "Failed to install module $1"
> -                    return 1
> +                if [[ "$_check" == "yes" ]] && [[ "$_silent" == "no" ]]; then
> +                    dfatal "Failed to install module $1"
>                  fi
>              }
>              shift
> 
> --
> To unsubscribe from this list: send the line "unsubscribe initramfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Well that's the purpose of "-c". Maybe we should better fix the call with "-c"
and/or react to the return code.