Re: [Intel-gfx] [PATCH] drm/i915: Enable XE_HP 4Tile support

[Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>]

On 21.12.2022 17.35, Jonathan Cavitt wrote:
> Add .has_4tile tag to XE_HP_FEATURES set.
> Remove duplicate entry from DG2_FEATURES.
> 
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> Cc: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
> Cc: Roper Matthew D <matthew.d.roper@intel.com>
> Cc: Kempczynski Zbigniew <Zbigniew.Kempczynski@intel.com>
> Cc: Telukuntla Sreedhar <sreedhar.telukuntla@intel.com>
> Acked-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_pci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 668e9da52584..7fd74cc28c0a 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -1017,6 +1017,7 @@ static const struct intel_device_info adl_p_info = {
>   	.has_3d_pipeline = 1, \
>   	.has_64bit_reloc = 1, \
>   	.has_flat_ccs = 1, \
> +	.has_4tile = 1, \

Order look wrong, should be between has_3d_pipeline and has_64bit_reloc. 
With that fixed:

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

>   	.has_global_mocs = 1, \
>   	.has_gt_uc = 1, \
>   	.has_llc = 1, \
> @@ -1061,7 +1062,6 @@ static const struct intel_device_info xehpsdv_info = {
>   	.__runtime.graphics.ip.rel = 55, \
>   	.__runtime.media.ip.rel = 55, \
>   	PLATFORM(INTEL_DG2), \
> -	.has_4tile = 1, \
>   	.has_64k_pages = 1, \
>   	.has_guc_deprivilege = 1, \
>   	.has_heci_pxp = 1, \