From: "Maxime Ripard" <mripard@kernel.org>
To: "Jim Cromie" <jim.cromie@gmail.com>
Cc: Maxime Ripard <mripard@kernel.org>, Emma Anholt <emma@anholt.net>,
jani.nikula@intel.com, daniel.vetter@ffwll.ch,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, seanpaul@chromium.org,
amd-gfx@lists.freedesktop.org, daniel@ffwll.ch,
David Airlie <airlied@gmail.com>,
intel-gvt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v3 4/5] drm/vc4: add trailing newlines to drm_dbg msgs
Date: Thu, 07 Sep 2023 06:51:59 +0000 [thread overview]
Message-ID: <040b316aae533abac3d3fa9c1eaff3d1.mripard@kernel.org> (raw)
In-Reply-To: <20230906190224.583577-5-jim.cromie@gmail.com>
On Wed, 6 Sep 2023 13:02:22 -0600, Jim Cromie wrote:
> By at least strong convention, a print-buffer's trailing newline says
> "message complete, send it". The exception (no TNL, followed by a call
> to pr_cont) proves the general rule.
>
> Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG,
>
> [ ... ]
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
next prev parent reply other threads:[~2023-09-07 6:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 19:02 [Intel-gfx] [PATCH v3 0/5] drm/drm_dbg: add trailing newlines where missing Jim Cromie
2023-09-06 19:02 ` [Intel-gfx] [PATCH v3 1/5] drm/connector: add trailing newlines to drm_dbg msgs Jim Cromie
2023-09-07 6:51 ` Maxime Ripard
2023-09-06 19:02 ` [Intel-gfx] [PATCH v3 2/5] drm/kmb: " Jim Cromie
2023-09-07 0:12 ` Chrisanthus, Anitha
2023-09-06 19:02 ` [Intel-gfx] [PATCH v3 3/5] drm/msm: " Jim Cromie
2023-09-06 20:29 ` Abhinav Kumar
2023-09-06 19:02 ` [Intel-gfx] [PATCH v3 4/5] drm/vc4: " Jim Cromie
2023-09-07 6:51 ` Maxime Ripard [this message]
2023-09-06 19:02 ` [Intel-gfx] [PATCH v3 5/5] drm/Makefile: use correct ccflags-y syntax Jim Cromie
2023-09-06 21:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/drm_dbg: add trailing newlines where missing Patchwork
2023-09-06 22:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-07 0:03 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=040b316aae533abac3d3fa9c1eaff3d1.mripard@kernel.org \
--to=mripard@kernel.org \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox