Re: [Intel-gfx] [PATCH 1/2] drm/i915: Declare .(de)gamma_lut_tests for icl+

["Shankar, Uma" <uma.shankar@intel.com>]

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Ville Syrjala
> Sent: Thursday, October 14, 2021 11:49 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 1/2] drm/i915: Declare .(de)gamma_lut_tests for icl+
> 
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> All interpolated gamma modes including the icl+ multi segment mode require non-
> decreasing entries for the interpolation to work correctly. For some reason we're
> forgetting to declare that for icl+. Let us do so.

Looks Good to me.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>

> References: https://gitlab.freedesktop.org/drm/intel/-/issues/3916
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_pci.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index
> 169837de395d..7655c7a4f904 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -145,6 +145,12 @@
>  		   .degamma_lut_tests = DRM_COLOR_LUT_NON_DECREASING | \
>  					DRM_COLOR_LUT_EQUAL_CHANNELS, \
>  	}
> +#define ICL_COLORS \
> +	.color = { .degamma_lut_size = 33, .gamma_lut_size = 262145, \
> +		   .degamma_lut_tests = DRM_COLOR_LUT_NON_DECREASING | \
> +					DRM_COLOR_LUT_EQUAL_CHANNELS, \
> +		   .gamma_lut_tests = DRM_COLOR_LUT_NON_DECREASING, \
> +	}
> 
>  /* Keep in gen based order, and chronological order within a gen */
> 
> @@ -811,7 +817,7 @@ static const struct intel_device_info cml_gt2_info = {
>  		[TRANSCODER_DSI_1] = TRANSCODER_DSI1_OFFSET, \
>  	}, \
>  	GEN(11), \
> -	.color = { .degamma_lut_size = 33, .gamma_lut_size = 262145 }, \
> +	ICL_COLORS, \
>  	.dbuf.size = 2048, \
>  	.dbuf.slice_mask = BIT(DBUF_S1) | BIT(DBUF_S2), \
>  	.display.has_dsc = 1, \
> --
> 2.32.0