Re: [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Add the missing CPU transcoder mask in intel_device_info

["Kalvala, Haridhar" <haridhar.kalvala@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1477 bytes --]


On 4/21/2023 3:42 AM, Radhakrishna Sripada wrote:
> CPU transcoder mask is used to iterate over the available
> CPU transcoders in the macro for_each_cpu_transcoder().
>
> The macro is broken on MTL and got highlighted when audio
> state was being tracked for each transcoder added in [1].
>
> Add the missing CPU transcoder mask which is similar to ADL-P
> mask but without DSI transcoders.
>
> [1]:https://patchwork.freedesktop.org/patch/523723/
>
> Fixes: 7835303982d1 ("drm/i915/mtl: Add MeteorLake PCI IDs")
> Cc: Ville Syrjälä<ville.syrjala@linux.intel.com>
> Signed-off-by: Radhakrishna Sripada<radhakrishna.sripada@intel.com>

Acked-by: Haridhar Kalvala <haridhar.kalvala@intel.com>

> ---
>   drivers/gpu/drm/i915/i915_pci.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index d64e074d7457..847057569796 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -1135,6 +1135,8 @@ static const struct intel_gt_definition xelpmp_extra_gt[] = {
>   static const struct intel_device_info mtl_info = {
>   	XE_HP_FEATURES,
>   	XE_LPDP_FEATURES,
> +	.__runtime.cpu_transcoder_mask = BIT(TRANSCODER_A) | BIT(TRANSCODER_B) |
> +			       BIT(TRANSCODER_C) | BIT(TRANSCODER_D),
>   	/*
>   	 * Real graphics IP version will be obtained from hardware GMD_ID
>   	 * register.  Value provided here is just for sanity checking.

-- 
Regards,
Haridhar Kalvala

[-- Attachment #2: Type: text/html, Size: 2736 bytes --]