From: Matthew Auld <matthew.auld@intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: rodrigo.vivi@intel.com
Subject: Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_virtual
Date: Mon, 24 Oct 2022 15:03:49 +0100 [thread overview]
Message-ID: <06019ccb-2833-0906-47e0-c30879ff5ec2@intel.com> (raw)
In-Reply-To: <20221021095525.788221-2-anshuman.gupta@intel.com>
On 21/10/2022 10:55, Anshuman Gupta wrote:
> We had already grabbed the rpm wakeref at obj destruction path,
> but it also required to grab the wakeref when object moves.
> When i915_gem_object_release_mmap_offset() gets called by
> i915_ttm_move_notify(), it will release the mmap offset without
> grabbing the wakeref. We want to avoid that therefore,
> grab the wakeref at i915_ttm_unmap_virtual() accordingly.
>
> While doing that also changed the lmem_userfault_lock from
> mutex to spinlock, as spinlock widely used for list.
>
> Also changed if (obj->userfault_count) to
> GEM_BUG_ON(!obj->userfault_count).
>
> v2:
> - Removed lmem_userfault_{list,lock} from intel_gt. [Matt Auld]
>
> Fixes: ad74457a6b5a ("drm/i915/dgfx: Release mmap on rpm suspend")
> Suggested-by: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
next prev parent reply other threads:[~2022-10-24 14:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 14:31 [Intel-gfx] [PATCH] drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_virtual Anshuman Gupta
2022-09-23 17:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-09-23 17:02 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-09-23 17:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-24 7:32 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-09-26 16:22 ` [Intel-gfx] [PATCH] " Matthew Auld
2022-09-27 12:30 ` Gupta, Anshuman
2022-09-27 12:45 ` Matthew Auld
2022-09-28 13:32 ` Gupta, Anshuman
2022-10-21 9:55 ` [Intel-gfx] [PATCH v2 1/2] drm/i915: Encapsulate lmem rpm stuff in intel_runtime_pm Anshuman Gupta
2022-10-21 9:55 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/dgfx: Grab wakeref at i915_ttm_unmap_virtual Anshuman Gupta
2022-10-24 14:03 ` Matthew Auld [this message]
2022-10-24 14:00 ` [Intel-gfx] [PATCH v2 1/2] drm/i915: Encapsulate lmem rpm stuff in intel_runtime_pm Matthew Auld
2022-10-31 6:42 ` Gupta, Anshuman
2022-10-31 9:34 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06019ccb-2833-0906-47e0-c30879ff5ec2@intel.com \
--to=matthew.auld@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox