From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [RFC 2/2] drm/i915: Use user engine names in error state ecode
Date: Wed, 4 Nov 2020 13:06:43 +0000 [thread overview]
Message-ID: <0651e52b-6840-b481-d3bc-3d36db1c8834@linux.intel.com> (raw)
In-Reply-To: <160449323247.15691.17140244371195703868@build.alporthouse.com>
On 04/11/2020 12:33, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2020-11-04 12:20:43)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Instead of printing out the internal engine mask, which can change between
>> kernel versions making it difficult to map to actual engines, list user
>> friendly engine names in the ecode string. For example:
>
> Nah. It's a nonsense number, just exists for quick and futile discrimination.
> Trying to interpret it is pointless.
>
> There's very little value to be gained from it, it should just serve as a
> tale-tell that we have captured an error state. The action and impact of
> the reset should be separately recorded.
My problem with the nonsense number is that we have it, but that is is
unstable and people are interpreting it.
How about a bitmask of uabi classes instead? As you can see I really
want something from the ABI-land, or not at all. Classes might be just
the thing for the purpose of a signature.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-11-04 13:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 12:20 [Intel-gfx] [RFC 1/2] drm/i915: Improve record of hung engines in error state Tvrtko Ursulin
2020-11-04 12:20 ` [Intel-gfx] [RFC 2/2] drm/i915: Use user engine names in error state ecode Tvrtko Ursulin
2020-11-04 12:33 ` Chris Wilson
2020-11-04 13:06 ` Tvrtko Ursulin [this message]
2020-11-04 13:21 ` Chris Wilson
2020-11-04 12:30 ` [Intel-gfx] [RFC 1/2] drm/i915: Improve record of hung engines in error state Chris Wilson
2020-11-04 13:03 ` Tvrtko Ursulin
2020-11-04 13:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [RFC,1/2] " Patchwork
2020-11-04 15:37 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0651e52b-6840-b481-d3bc-3d36db1c8834@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox