From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] i915/perf: Drop the check for report reason in OA
Date: Thu, 11 Feb 2021 13:01:28 +0200 [thread overview]
Message-ID: <06bb7241-3da4-ac24-95ce-130d2f8a6722@intel.com> (raw)
In-Reply-To: <20210210190106.8586-1-umesh.nerlige.ramappa@intel.com>
On 10/02/2021 21:01, Umesh Nerlige Ramappa wrote:
> After fixing the OA_TAIL_PTR corruption, there are no more reports with
> reason field of zero. Drop the check for report reason.
>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
I thought I push this patch already :|
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
> drivers/gpu/drm/i915/i915_perf.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index 93f3e2c5c89a..c15bead2dac7 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -725,11 +725,6 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
> (IS_GEN(stream->perf->i915, 12) ?
> OAREPORT_REASON_MASK_EXTENDED :
> OAREPORT_REASON_MASK));
> - if (reason == 0) {
> - if (__ratelimit(&stream->perf->spurious_report_rs))
> - DRM_NOTE("Skipping spurious, invalid OA report\n");
> - continue;
> - }
>
> ctx_id = report32[2] & stream->specific_ctx_id_mask;
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-02-11 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 19:01 [Intel-gfx] [PATCH] i915/perf: Drop the check for report reason in OA Umesh Nerlige Ramappa
2021-02-10 19:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for i915/perf: Drop the check for report reason in OA (rev2) Patchwork
2021-02-11 10:51 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-02-11 11:01 ` Lionel Landwerlin [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-12-02 4:25 [Intel-gfx] [PATCH] i915/perf: Drop the check for report reason in OA Umesh Nerlige Ramappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06bb7241-3da4-ac24-95ce-130d2f8a6722@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox