Re: [PATCH] drm/i915/psr: eDP Panel Replay is not supported on pipes other than A and B

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Wed, 2024-09-18 at 06:17 +0000, Manna, Animesh wrote:
> 
> 
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf
> > Of Jouni
> > Högander
> > Sent: Monday, September 16, 2024 2:27 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Hogander, Jouni <jouni.hogander@intel.com>
> > Subject: [PATCH] drm/i915/psr: eDP Panel Replay is not supported on
> > pipes
> > other than A and B
> > 
> > Do not allow Panel Replay if pipe is other than A or B.
> > 
> > Bspec: 68920
> > 
> > Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2736
> > Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> 
> Reviewed-by: Animesh Manna <animesh.manna@intel.com>

Thank you Animesh for your review. This is now pushed to drm-intel-
next.

BR,

Jouni Högander

> 
> > ---
> >  drivers/gpu/drm/i915/display/intel_psr.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > b/drivers/gpu/drm/i915/display/intel_psr.c
> > index 1a4ef231a53ca..699892b8c967a 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -1582,6 +1582,10 @@ _panel_replay_compute_config(struct intel_dp
> > *intel_dp,
> > 
> >         /* Remaining checks are for eDP only */
> > 
> > +       if (to_intel_crtc(crtc_state->uapi.crtc)->pipe != PIPE_A &&
> > +           to_intel_crtc(crtc_state->uapi.crtc)->pipe != PIPE_B)
> > +               return false;
> > +
> >         /* 128b/132b Panel Replay is not supported on eDP */
> >         if (intel_dp_is_uhbr(crtc_state)) {
> >                 drm_dbg_kms(display->drm,
> > --
> > 2.34.1
>