Re: [PATCH v2 1/1] i915/i915_driver: move intel_gvt_init() level higher

["Michał Grzelak" <michal.grzelak@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1713 bytes --]

On Thu, 29 Jan 2026, Andi Shyti wrote:
> Hi Michal,
>
> On Thu, Jan 29, 2026 at 10:01:29AM +0100, Michał Grzelak wrote:
>> Both initialisation and removal of GVT happen at different abstraction
>> levels. Hence caller of i915_driver_hw_probe() has no way of knowing
>> status of intel_gvt_init(). This can lead to an unbalanced number of
>> calls of intel_gvt_init() and intel_gvt_driver_remove() since GVT error
>> path is currently handled in i915_driver_probe(). One such scenario has
>> been seen with i915_driver_hw_probe() fault injection, which caused
>> double entry deletion and list corruption.
>>
>> Move intel_gvt_init() up to i915_driver_probe(). Add out_cleanup_gvt
>> error path for removing gvt. Trigger it only after intel_gvt_init()
>> succeeded.
>>
>> In case intel_gvt_init() failed, theoretically we should follow err_msi
>> error path. That is actually impossible since call to intel_gvt_init()
>> unconditionally returns 0, although it claims to return negative error
>> code on failure. Thus follow standard out_cleanup_hw error path on a
>> hypothetical future intel_gvt_init() failure. Remove err_msi label from
>> i915_driver_hw_probe() since intel_gvt_init() was the only user of it.
>>
>> Changelog:
>> v1->v2
>> - don't move err_msi error path from i915_driver_hw_probe (Jani)
>> - rewrite commit message
>>
>> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15481
>> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thank you Andi for the review. Do you have any suggestion via which tree
should the patch be merged? Asking since I don't have commit right to
any of drm-* repositories.

BR,
Michał