From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>,
"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 4/5] drm/i915/frontbuffer: Remove early frontbuffer flush in prepare_plane_fb()
Date: Mon, 19 Feb 2018 10:07:26 +0100 [thread overview]
Message-ID: <0bc713a9-e775-b52c-7abd-4013af68d215@linux.intel.com> (raw)
In-Reply-To: <1518810622.18148.29.camel@dk-H97M-D3H>
Op 16-02-18 om 20:27 schreef Pandiyan, Dhinakaran:
> On Fri, 2018-02-16 at 08:55 +0000, Chris Wilson wrote:
>> Quoting Dhinakaran Pandiyan (2018-02-16 04:33:21)
>>> Preparing a framebuffer should not require a flush. _post_plane_update()
>>> takes care of flushing when a flip is scheduled, this should be
>>> sufficient for PSR and FBC.
>> Makes sense.
>>
> I also think this might speed up the flips a bit by avoiding flushes.
>
>>> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
>>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>>> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>> Also
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> to validate the flow through atomic.
>> -Chris
>>
Page flips used to do intel_frontbuffer_flip_prepare here, followed by intel_frontbuffer_flip_complete. I think it would make sense to change the patch to do that?
Then again, seems like frontbuffer tracking should be done per crtc..
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-19 9:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 4:33 [PATCH 1/5] drm/i915/frontbuffer: Pull frontbuffer_flush out of gem_obj_pin_to_display Dhinakaran Pandiyan
2018-02-16 4:33 ` [PATCH 2/5] drm/i915/psr: Use more PSR HW tracking Dhinakaran Pandiyan
2018-02-16 8:54 ` Chris Wilson
2018-03-07 3:54 ` Pandiyan, Dhinakaran
2018-02-16 4:33 ` [PATCH 3/5] drm/i915/frontbuffer: HW tracking for cursor moves to fix PSR lags Dhinakaran Pandiyan
2018-02-16 4:33 ` [PATCH 4/5] drm/i915/frontbuffer: Remove early frontbuffer flush in prepare_plane_fb() Dhinakaran Pandiyan
2018-02-16 8:55 ` Chris Wilson
2018-02-16 19:27 ` Pandiyan, Dhinakaran
2018-02-19 9:07 ` Maarten Lankhorst [this message]
2018-02-24 3:24 ` Pandiyan, Dhinakaran
2018-02-28 20:28 ` Ville Syrjälä
2018-02-28 20:38 ` Ville Syrjälä
2018-02-28 23:38 ` Pandiyan, Dhinakaran
2018-03-01 10:51 ` Ville Syrjälä
2018-03-01 11:22 ` Ville Syrjälä
2018-03-01 18:35 ` Rodrigo Vivi
2018-03-01 18:43 ` Ville Syrjälä
2018-03-01 19:00 ` Rodrigo Vivi
2018-03-01 19:21 ` Pandiyan, Dhinakaran
2018-03-01 19:24 ` Ville Syrjälä
2018-02-16 4:33 ` [PATCH 5/5] drm/i915/psr: Wait for PSR transition to complete before exiting Dhinakaran Pandiyan
2018-02-16 8:58 ` Chris Wilson
2018-02-16 18:58 ` Pandiyan, Dhinakaran
2018-02-16 4:38 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915/frontbuffer: Pull frontbuffer_flush out of gem_obj_pin_to_display Patchwork
2018-02-16 4:54 ` ✓ Fi.CI.BAT: success " Patchwork
2018-02-16 8:52 ` [PATCH 1/5] " Chris Wilson
2018-02-16 19:22 ` Pandiyan, Dhinakaran
2018-02-16 11:55 ` ✓ Fi.CI.IGT: success for series starting with [1/5] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bc713a9-e775-b52c-7abd-4013af68d215@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox