Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vignesh Raman <vignesh.raman@collabora.com>
To: Daniel Stone <daniel@fooishbar.org>
Cc: dri-devel@lists.freedesktop.org, daniels@collabora.com,
	helen.koike@collabora.com, airlied@gmail.com, daniel@ffwll.ch,
	robdclark@gmail.com, guilherme.gallo@collabora.com,
	sergi.blanch.torne@collabora.com, deborah.brouwer@collabora.com,
	dmitry.baryshkov@linaro.org, linux-arm-msm@vger.kernel.org,
	intel-gfx@lists.freedesktop.org, virtualization@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] drm/ci: refactor software-driver stage jobs
Date: Tue, 22 Oct 2024 12:55:54 +0530	[thread overview]
Message-ID: <0cd1d4af-ee47-468a-be70-ee2c30948eb8@collabora.com> (raw)
In-Reply-To: <CAPj87rPGD8Pu_CSPXfRtsS_w8UYVJGR9CoLx7RAT69EUKefs3A@mail.gmail.com>

Hi Daniel,

On 07/10/24 22:07, Daniel Stone wrote:
> Hi Vignesh,
> 
> On Fri, 4 Oct 2024 at 09:31, Vignesh Raman <vignesh.raman@collabora.com> wrote:
>> +.software-driver:
>> +  stage: software-driver
>> +  extends:
>> +    - .test-gl
>> +    - .test-rules
>> +  timeout: "1h30m"
>> +  tags:
>> +    - kvm
>> +  script:
>> +    - ln -sf $CI_PROJECT_DIR/install /install
>> +    - mv install/bzImage /lava-files/bzImage
>> +    - mkdir -p /lib/modules
>> +    - mkdir -p $CI_PROJECT_DIR/results
>> +    - ln -sf $CI_PROJECT_DIR/results /results
>> +    - install/crosvm-runner.sh install/igt_runner.sh
> 
> Instead of inlining this here, can we please move towards reusing more
> of .gitlab-ci/common/init-stage[12].sh? If those files need to be
> modified then that's totally fine, but I'd rather have something more
> predictable, and fewer random pieces of shell in each job section.

Sure. I will look into init-stage[12].sh and see if we can reuse it. Thanks.

Regards,
Vignesh

  reply	other threads:[~2024-10-22  7:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 13:31 [PATCH v1 0/3] drm/ci: add new devices for testing Vignesh Raman
2024-10-04 13:31 ` [PATCH v1 1/3] drm/ci: refactor software-driver stage jobs Vignesh Raman
2024-10-07 16:37   ` Daniel Stone
2024-10-22  7:25     ` Vignesh Raman [this message]
2024-10-04 13:31 ` [PATCH v1 2/3] drm/ci: add dedede Vignesh Raman
2024-10-04 13:31 ` [PATCH v1 3/3] drm/ci: add sm8350-hdk Vignesh Raman
2024-10-06 19:46   ` Dmitry Baryshkov
2024-10-09 19:40   ` Abhinav Kumar
2024-10-08  0:46 ` ✗ Fi.CI.CHECKPATCH: warning for drm/ci: add new devices for testing Patchwork
2024-10-08  0:55 ` ✓ Fi.CI.BAT: success " Patchwork
2024-10-09  1:56 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cd1d4af-ee47-468a-be70-ee2c30948eb8@collabora.com \
    --to=vignesh.raman@collabora.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=daniel@fooishbar.org \
    --cc=daniels@collabora.com \
    --cc=deborah.brouwer@collabora.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=guilherme.gallo@collabora.com \
    --cc=helen.koike@collabora.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=sergi.blanch.torne@collabora.com \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox