Re: [Intel-gfx] [PATCH] drm/i915/hwconfig: Future-proof platform checks

[John Harrison <john.c.harrison@intel.com>]

On 5/24/2022 16:59, Matt Roper wrote:
> PVC also has a hwconfig table.  Actually the current expectation is that
> all future platforms will have hwconfig, so let's just change the
> condition to an IP version check so that we don't need to keep updating
> this for each new platform that shows up.
>
> Cc: John Harrison <john.c.harrison@intel.com>
> Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>

> ---
>   drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
> index 5aaa3948de74..4781fccc2687 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
> @@ -96,7 +96,7 @@ static bool has_table(struct drm_i915_private *i915)
>   {
>   	if (IS_ALDERLAKE_P(i915) && !IS_ADLP_N(i915))
>   		return true;
> -	if (IS_DG2(i915))
> +	if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 55))
>   		return true;
>   
>   	return false;