From: Maciej Patelczyk <maciej.patelczyk@intel.com>
To: Krzysztof Karas <krzysztof.karas@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: replace in_atomic() with manually set flag
Date: Mon, 3 Feb 2025 12:46:50 +0100 [thread overview]
Message-ID: <0dd1cfff-82be-497d-8f39-b78e5211f376@intel.com> (raw)
In-Reply-To: <4gavatglum2ln324cjhzjdnvtio4m7r4nq3uhophbgajg66hho@iq7hqpgj5ezc>
On 28.01.2025 10:29, Krzysztof Karas wrote:
> Hi Maciej,
>
>> The locked==true looks OK.
>>
> thanks for review!
>
>> However, I fear that there is some corner case with locked==false. 1 or 2
>> calls back in chain looks good.
>>
>> CI failures needs to be analyzed.
>>
> Yup, I already did that recently. I thought those were
> suspicious, but I could not reproduce them locally on the
> same platforms (I ran singluar tests and whole test suites from
> igt_runner*.txt files as well). I re-triggered the tests for
> that patch and the failures did not appear again:
> https://patchwork.freedesktop.org/series/143402/#rev2
>
> Krzysztof
Looks good to me.
Reviewed-by: Maciej Patelczyk <maciej.patelczyk@intel.com>
next prev parent reply other threads:[~2025-02-03 11:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 15:46 [PATCH] drm/i915: replace in_atomic() with manually set flag Krzysztof Karas
2025-01-10 16:37 ` ✗ Fi.CI.SPARSE: warning for " Patchwork
2025-01-10 17:03 ` ✓ i915.CI.BAT: success " Patchwork
2025-01-14 18:56 ` ✗ i915.CI.Full: failure " Patchwork
2025-01-23 14:47 ` [PATCH] " Maciej Patelczyk
2025-01-28 9:29 ` Krzysztof Karas
2025-02-03 11:46 ` Maciej Patelczyk [this message]
2025-01-27 19:09 ` ✗ Fi.CI.SPARSE: warning for drm/i915: replace in_atomic() with manually set flag (rev2) Patchwork
2025-01-27 19:26 ` ✓ i915.CI.BAT: success " Patchwork
2025-01-27 22:51 ` ✓ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dd1cfff-82be-497d-8f39-b78e5211f376@intel.com \
--to=maciej.patelczyk@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=krzysztof.karas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox