From: "Souza, Jose" <jose.souza@intel.com>
To: "keescook@chromium.org" <keescook@chromium.org>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Do not zero past infoframes.vsc
Date: Thu, 17 Jun 2021 21:39:35 +0000 [thread overview]
Message-ID: <11498e1539b668ff6d6ce841b6db6aa70cf51180.camel@intel.com> (raw)
In-Reply-To: <20210617213301.1824728-1-keescook@chromium.org>
On Thu, 2021-06-17 at 14:33 -0700, Kees Cook wrote:
> intel_dp_vsc_sdp_unpack() was using a memset() size (36, struct dp_sdp)
> larger than the destination (24, struct drm_dp_vsc_sdp), clobbering
> fields in struct intel_crtc_state after infoframes.vsc. Use the actual
> target size for the memset().
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
>
> Fixes: 1b404b7dbb10 ("drm/i915/dp: Read out DP SDPs")
> Cc: stable@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 5c9222283044..6cc03b9e4321 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2868,7 +2868,7 @@ static int intel_dp_vsc_sdp_unpack(struct drm_dp_vsc_sdp *vsc,
> if (size < sizeof(struct dp_sdp))
> return -EINVAL;
>
> - memset(vsc, 0, size);
> + memset(vsc, 0, sizeof(*vsc));
>
> if (sdp->sdp_header.HB0 != 0)
> return -EINVAL;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-06-17 21:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 21:33 [Intel-gfx] [PATCH] drm/i915/display: Do not zero past infoframes.vsc Kees Cook
2021-06-17 21:39 ` Souza, Jose [this message]
2021-06-17 23:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-06-18 0:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-06-18 3:42 ` Kees Cook
2021-06-21 19:38 ` Souza, Jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11498e1539b668ff6d6ce841b6db6aa70cf51180.camel@intel.com \
--to=jose.souza@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keescook@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox