Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Aurélien <aurelien.intel@ap2c.com>
To: "Jani Nikula" <jani.nikula@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Hans de Goede" <hdegoede@redhat.com>, "Lyude" <lyude@redhat.com>,
	dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] Developing a new backlight driver for specific OLED screen
Date: Fri, 09 Sep 2022 15:49:24 +0000	[thread overview]
Message-ID: <115b5a5ebddcd268ee5f7688400448a2@ap2c.com> (raw)
In-Reply-To: <878rms7emr.fsf@intel.com>

Hi, 

> + dri-devel mailing list that looks more appropriated.
> + Hans and Lyude who were recently working to standardize some of the
> backlight stuff.

Thank you for these contacts. I'll try there if I need.

> I don't believe you want to use the i915 API, but move the common functions
> to the drm subsystem itself and then reuse as a drm device.

If there is enough generic code I'll do everything with the DRM API. Unfortunately I can't spend too much time in order to generalize the i915 common functions.

> Aurélien, are you aware of drivers/gpu/drm/display/drm_dp_helper.c and
> all the functions around struct dp_aux_backlight and struct
> drm_edp_backlight_info?

Not yet. Since I'm not familiar with GPU/display drivers I didn't know what could be a good starting point. 
Indeed I already checked the intel_dp_aux_backlight.c code. That's why I told about using the "i915 API code" at first. But since this display is independent from the GPU i didn't want to link both code. 
Then that's a really good point if there is already an independant API. I'll have a look this evening.

> Does the display use some proprietary, non-VESA DPCD registers? There's
> already some of that in i915 for Intel proprietary interfaces.

For sure. It's an OLED display. Thus there is no backlight. It uses specific registers to control the brightness of the screen.
Unfortunately I guess the mechanism is not shared with many OLED displays...

Thank you for your help.

Aurélien

  reply	other threads:[~2022-09-09 15:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09  9:35 [Intel-gfx] Developing a new backlight driver for specific OLED screen Aurélien
2022-09-09  9:50 ` Rodrigo Vivi
2022-09-09 15:26   ` Jani Nikula
2022-09-09 15:49     ` Aurélien [this message]
2022-09-09 18:20       ` Lyude Paul
2022-09-12  8:44       ` Jani Nikula
2022-10-28 15:53         ` Aurélien
2022-10-31  8:40           ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=115b5a5ebddcd268ee5f7688400448a2@ap2c.com \
    --to=aurelien.intel@ap2c.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hdegoede@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=lyude@redhat.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox