From: Alexey Fisher <bug-track@fisher-privat.net>
To: Peter Clifton <pcjc2@cam.ac.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: Corruption in glxgears with Compiz
Date: Sat, 23 Oct 2010 10:23:19 +0200 [thread overview]
Message-ID: <1287822199.5449.1.camel@zwerg> (raw)
In-Reply-To: <1287806877.2423.3.camel@pcjc2lap>
Am Samstag, den 23.10.2010, 05:07 +0100 schrieb Peter Clifton:
> On Sat, 2010-10-23 at 04:35 +0100, Peter Clifton wrote:
>
> > Lost of bisecting and backporting later.. and I've identified the bad
> > commit:
> >
> > 9220434a8768902cd9cf248709972678b74aa8c1 drm/i915: Only emit a flush
> > request on the active ring.
>
> A minimal fix is this:
>
> commit 78342e8fd01614ac0507db1f9c3e0522f4da3c14
> Author: Peter Clifton <pcjc2@cam.ac.uk>
> Date: Sat Oct 23 04:00:21 2010 +0100
>
> Attempted fix
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 9290f02..868a399 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -3759,7 +3759,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
> */
> dev->invalidate_domains = 0;
> dev->flush_domains = 0;
> - dev_priv->mm.flush_rings = 0;
> + dev_priv->mm.flush_rings = ring->id;
>
> for (i = 0; i < args->buffer_count; i++) {
> struct drm_gem_object *obj = object_list[i];
>
>
>
>
Can only add here, me too. This patch fix it on my board too.
next prev parent reply other threads:[~2010-10-23 8:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 12:53 Corruption in glxgears with Compiz Peter Clifton
2010-10-22 13:39 ` Chris Wilson
2010-10-22 14:04 ` Alexey Fisher
2010-10-22 19:10 ` Peter Clifton
2010-10-22 19:29 ` Chris Wilson
2010-10-22 19:38 ` Peter Clifton
2010-10-22 20:41 ` Peter Clifton
2010-10-23 3:35 ` Peter Clifton
2010-10-23 4:07 ` Peter Clifton
2010-10-23 8:23 ` Alexey Fisher [this message]
2010-10-23 9:10 ` Chris Wilson
2010-10-23 9:43 ` Alexey Fisher
2010-10-23 10:07 ` Chris Wilson
2010-10-23 11:42 ` Peter Clifton
2010-10-23 17:48 ` Chris Wilson
2010-10-23 18:33 ` Peter Clifton
2010-10-24 23:06 ` Peter Clifton
2010-10-22 19:13 ` Peter Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287822199.5449.1.camel@zwerg \
--to=bug-track@fisher-privat.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=pcjc2@cam.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox