From: Peter Clifton <pcjc2@cam.ac.uk>
To: Eric Anholt <eric@anholt.net>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: intel_prepare_render(intel); unhelpful?
Date: Mon, 01 Nov 2010 22:19:34 +0000 [thread overview]
Message-ID: <1288649974.2854.5.camel@pcjc2lap> (raw)
In-Reply-To: <874oc0203e.fsf@pollan.anholt.net>
On Mon, 2010-11-01 at 14:41 -0700, Eric Anholt wrote:
> > I'm going to look at the case I "think" I hit an improvement for and
> > dissect _why_, then get back to you.
I'll check this again shortly.. (I recall I was testing this with the
display lists anyway)..
> > I'm chasing my code right now to see why it is emitting lots of batches
> > when not using display lists for benchmarking purposes. I got my figures
> > muddled up before.. I'm seeing 5 batches / frame when using Display
> > lists, and nearer 40 when not. (I previously reported the other way
> > around).
>
> I'd love to know too. INTEL_DEBUG=state (in the midst of much other
> spam) dumps out a report of how many times various state changes got
> flagged, which may highlight a change between the two modes.
The large number of batches was due to a dumb dumb thing I was doing
with VBOs.. rather than just discarding the memory after rendering some
primitives, I was mapping the same VBO and re-uploading, causing
synchronisation.
Actually, I had two VBOs and was alternating between them, but was still
of course causing synchronisation at the map stage. Fixed now, so my non
display-list code is much faster again.
I guess it kind of begs the question why the compiled display list needs
4 or 5 batches to do what my own code manages in 1.
--
Peter Clifton
Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA
Tel: +44 (0)7729 980173 - (No signal in the lab!)
Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)
next prev parent reply other threads:[~2010-11-01 22:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-31 1:15 intel_prepare_render(intel); unhelpful? Peter Clifton
2010-11-01 3:54 ` Eric Anholt
2010-11-01 19:20 ` Peter Clifton
2010-11-01 19:52 ` Peter Clifton
2010-11-01 20:17 ` Eric Anholt
[not found] ` <1288645484.2714.2.camel@pcjc2lap>
[not found] ` <874oc0203e.fsf@pollan.anholt.net>
2010-11-01 22:19 ` Peter Clifton [this message]
2010-11-02 15:40 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288649974.2854.5.camel@pcjc2lap \
--to=pcjc2@cam.ac.uk \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox