public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Zhigang Gong <zhigang.gong@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 4/4] glamor: Silence compilation warnings.
Date: Mon, 14 Nov 2011 20:09:04 +0800	[thread overview]
Message-ID: <1321272544-29722-4-git-send-email-zhigang.gong@linux.intel.com> (raw)
In-Reply-To: <1321272544-29722-1-git-send-email-zhigang.gong@linux.intel.com>

As we removed those #ifdef from the body of the code, some
functions are referenced even we haven't defined the GLAMOR
though those functions are never be called at run time. We
still need to inclue those prototypes or make a fake function
to silcent the compilation warnings.

Signed-off-by: Zhigang Gong <zhigang.gong@linux.intel.com>
---
 src/intel_driver.c |    2 --
 src/intel_uxa.c    |    2 --
 uxa/uxa-accel.c    |    5 ++++-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/intel_driver.c b/src/intel_driver.c
index bd57694..0f528f3 100644
--- a/src/intel_driver.c
+++ b/src/intel_driver.c
@@ -75,9 +75,7 @@ USE OR OTHER DEALINGS IN THE SOFTWARE.
 #include "i915_drm.h"
 #include <xf86drmMode.h>
 
-#ifdef GLAMOR
 #include "intel_glamor.h"
-#endif
 
 /* *INDENT-OFF* */
 /*
diff --git a/src/intel_uxa.c b/src/intel_uxa.c
index a069980..81d5ec0 100644
--- a/src/intel_uxa.c
+++ b/src/intel_uxa.c
@@ -40,9 +40,7 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #include <string.h>
 #include <errno.h>
 
-#ifdef GLAMOR
 #include "intel_glamor.h"
-#endif
 
 static const int I830CopyROP[16] = {
 	ROP_0,			/* GXclear */
diff --git a/uxa/uxa-accel.c b/uxa/uxa-accel.c
index b2e5347..5b27aaa 100644
--- a/uxa/uxa-accel.c
+++ b/uxa/uxa-accel.c
@@ -38,7 +38,10 @@
 
 #ifdef GLAMOR
 #include "glamor.h"
-#endif
+#else
+#define glamor_fill_spans_nf(...)  FALSE
+#define glamor_poly_fill_rect_nf(...) FALSE
+#endif 
 
 static void
 uxa_fill_spans(DrawablePtr pDrawable, GCPtr pGC, int n,
-- 
1.7.4.4

      parent reply	other threads:[~2011-11-14 12:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14 12:09 [PATCH 1/4] glamor: Added flags to indicate whether to use glamor in UXA Zhigang Gong
2011-11-14 12:09 ` [PATCH 2/4] glamor: Added new data element to track uxa flags in intel structure Zhigang Gong
2011-11-14 12:09 ` [PATCH 3/4] glamor: check a flag to indicate whether enable GLAMOR Zhigang Gong
2011-11-14 14:47   ` Chris Wilson
2011-11-14 12:09 ` Zhigang Gong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321272544-29722-4-git-send-email-zhigang.gong@linux.intel.com \
    --to=zhigang.gong@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox