From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 1/3] drm/i915: s/i915_gem_do_init/i915_gem_init_global_gtt
Date: Mon, 26 Mar 2012 09:48:01 +0100 [thread overview]
Message-ID: <1332751691_97010@CP5-2952> (raw)
In-Reply-To: <1332747942-2143-1-git-send-email-daniel.vetter@ffwll.ch>
On Mon, 26 Mar 2012 09:45:40 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> int
> i915_gem_init_ioctl(struct drm_device *dev, void *data,
> struct drm_file *file)
> @@ -155,7 +136,8 @@ i915_gem_init_ioctl(struct drm_device *dev, void *data,
> return -EINVAL;
>
> mutex_lock(&dev->struct_mutex);
> - i915_gem_do_init(dev, args->gtt_start, args->gtt_end, args->gtt_end);
> + i915_gem_init_global_gtt(dev, args->gtt_start,
> + args->gtt_end, args->gtt_end);
> mutex_unlock(&dev->struct_mutex);
>
> return 0;
This raises the interesting question of ppgtt interacting with DRI1, a
never supported combination. Do we start making that expressly clear
with a few if (HAS_ALIASING_PPGTT()) return -ENODEV; or even if (gen >=
6) return -ENODEV; ?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-03-26 8:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 7:45 [PATCH 1/3] drm/i915: s/i915_gem_do_init/i915_gem_init_global_gtt Daniel Vetter
2012-03-26 7:45 ` [PATCH 2/3] drm/i915: the intel gtt is _not_ an agp bridge! Daniel Vetter
2012-03-26 8:49 ` Chris Wilson
2012-03-26 9:03 ` Daniel Vetter
2012-03-27 11:15 ` Daniel Vetter
2012-03-26 7:45 ` [PATCH 3/3] drm/i915: clear the entire gtt when using gem Daniel Vetter
2012-03-26 8:48 ` Chris Wilson [this message]
2012-03-26 8:58 ` [PATCH 1/3] drm/i915: s/i915_gem_do_init/i915_gem_init_global_gtt Daniel Vetter
2012-03-28 19:39 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332751691_97010@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox