From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: don't clobber the special upscaling lvds timings
Date: Sat, 14 Apr 2012 17:43:49 +0100 [thread overview]
Message-ID: <1334421840_64@CP5-2952> (raw)
In-Reply-To: <1334420277-19302-1-git-send-email-daniel.vetter@ffwll.ch>
On Sat, 14 Apr 2012 18:17:57 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> This regression has been introduced in
>
> commit ca9bfa7eed20ea34e862804e62aae10eb159edbb
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Sat Jan 28 14:49:20 2012 +0100
>
> drm/i915: fixup interlaced vertical timings confusion, part 1
>
> Unfortunately that commit failed to take into account that the lvds
> code does some special adjustements to the crtc timings for upscaling
> an centering.
>
> Fix this by explicitly computing crtc timings in the lvds mode fixup
> function and setting a special flag in mode->private_flags if the crtc
> timings have been adjusted.
Whilst the patch does what it says on the tin, I think this just
underlines the fact that our handling of crtcinfo is just wrong and
consists of fragile hacks. :(
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-04-14 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 16:17 [PATCH] drm/i915: don't clobber the special upscaling lvds timings Daniel Vetter
2012-04-14 16:43 ` Chris Wilson [this message]
2012-04-14 16:54 ` Daniel Vetter
2012-04-14 17:05 ` Chris Wilson
2012-04-15 15:07 ` Eugeni Dodonov
2012-04-15 15:19 ` Eugeni Dodonov
2012-04-15 17:24 ` Daniel Vetter
2012-04-15 17:38 ` Chris Wilson
2012-04-15 17:53 ` Daniel Vetter
2012-04-15 18:03 ` Chris Wilson
2012-04-16 7:34 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334421840_64@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox