From: Adam Jackson <ajax@redhat.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 09/12] drm/edid: Update range descriptor struct for EDID 1.4
Date: Tue, 17 Apr 2012 13:17:31 -0400 [thread overview]
Message-ID: <1334683051.32618.0.camel@atropine> (raw)
In-Reply-To: <s5h3982qt22.wl%tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 953 bytes --]
On Tue, 2012-04-17 at 17:25 +0200, Takashi Iwai wrote:
> At Fri, 13 Apr 2012 16:33:37 -0400, Adam Jackson wrote:
> > + u8 flags;
> > + union {
> > + struct {
> > + u8 reserved;
> > + u8 hfreq_start_khz; /* need to multiply by 2 */
> > + u8 c; /* need to divide by 2 */
> > + __le16 m;
> > + u8 k;
> > + u8 j; /* need to divide by 2 */
> > + } gtf2;
> > + struct {
> > + u8 version;
> > + u8 data1; /* high 6 bits: extra clock resolution */
> > + u8 data2; /* plus low 2 of above: max hactive */
> > + u8 supported_aspects;
> > + u8 flags; /* preferred aspect and blanking support */
> > + u8 supported_scalings;
> > + u8 preferred_refresh;
> > + } cvt;
>
> These new structs must be marked with __attribute__((packed)) although
> the struct detailed_data_monitor_range itself is already marked. At
> least, with gcc 4.6 and x86-64 here, they get unaligned.
Eek. Good catch, thanks.
- ajax
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2012-04-17 17:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 20:33 [PATCH 00/12] Add more DMT and common modes Adam Jackson
2012-04-13 20:33 ` [PATCH 01/12] drm/edid: Document drm_mode_find_dmt Adam Jackson
2012-04-13 20:33 ` [PATCH 02/12] drm/edid: Rewrite drm_mode_find_dmt search loop Adam Jackson
2012-04-13 20:33 ` [PATCH 03/12] drm/edid: Allow drm_mode_find_dmt to hunt for reduced-blanking modes Adam Jackson
2012-04-13 20:33 ` [PATCH 04/12] drm/edid: Remove a misleading comment Adam Jackson
2012-04-13 20:33 ` [PATCH 05/12] drm/edid: s/drm_gtf_modes_for_range/drm_dmt_modes_for_range/ Adam Jackson
2012-04-13 20:33 ` [PATCH 06/12] drm/edid: Add the reduced blanking DMT modes to the DMT list Adam Jackson
2012-04-13 20:33 ` [PATCH 07/12] drm/edid: Fix some comment typos in the DMT mode list Adam Jackson
2012-04-13 20:33 ` [PATCH 08/12] drm/edid: Do drm_dmt_modes_for_range() for all range descriptor types Adam Jackson
2012-04-13 20:33 ` [PATCH 09/12] drm/edid: Update range descriptor struct for EDID 1.4 Adam Jackson
2012-04-17 15:25 ` [Intel-gfx] " Takashi Iwai
2012-04-17 17:17 ` Adam Jackson [this message]
2012-04-13 20:33 ` [PATCH 10/12] drm/edid: Give the est3 mode struct a real name Adam Jackson
2012-04-13 20:33 ` [PATCH 11/12] drm/edid: Add extra_modes Adam Jackson
2012-04-13 20:33 ` [PATCH 12/12] drm/edid: Generate modes from extra_modes for range descriptors Adam Jackson
2012-04-13 20:56 ` [PATCH 00/12] Add more DMT and common modes Adam Jackson
2012-04-17 15:26 ` [Intel-gfx] " Takashi Iwai
2012-04-19 12:03 ` Takashi Iwai
2012-04-19 14:58 ` Takashi Iwai
2012-04-20 12:05 ` Dave Airlie
2012-04-20 12:34 ` Takashi Iwai
2012-04-20 12:04 ` [Intel-gfx] " Dave Airlie
2012-04-20 12:32 ` Takashi Iwai
2012-04-17 15:33 ` Takashi Iwai
2012-04-17 15:50 ` Takashi Iwai
2012-04-17 16:02 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334683051.32618.0.camel@atropine \
--to=ajax@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox