From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH 02/17] drm/i915: create dev_priv->dri1 dragon dungeon^W^W sub-struct
Date: Thu, 26 Apr 2012 23:28:02 +0200 [thread overview]
Message-ID: <1335475697-3069-3-git-send-email-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <1335475697-3069-1-git-send-email-daniel.vetter@ffwll.ch>
... and shove allow_batchbuffer in there. More dragons will
follow suit.
There's the curious case that we allow this for KMS ...
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/i915_dma.c | 8 ++++----
drivers/gpu/drm/i915/i915_drv.h | 11 ++++++++++-
drivers/gpu/drm/i915/i915_gem.c | 2 +-
3 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
index 653fc86..0da8f12 100644
--- a/drivers/gpu/drm/i915/i915_dma.c
+++ b/drivers/gpu/drm/i915/i915_dma.c
@@ -198,7 +198,7 @@ static int i915_initialize(struct drm_device * dev, drm_i915_init_t * init)
/* Allow hardware batchbuffers unless told otherwise.
*/
- dev_priv->allow_batchbuffer = 1;
+ dev_priv->dri1.allow_batchbuffer = 1;
return 0;
}
@@ -610,7 +610,7 @@ static int i915_batchbuffer(struct drm_device *dev, void *data,
if (drm_core_check_feature(dev, DRIVER_MODESET))
return -ENODEV;
- if (!dev_priv->allow_batchbuffer) {
+ if (!dev_priv->dri1.allow_batchbuffer) {
DRM_ERROR("Batchbuffer ioctl disabled\n");
return -EINVAL;
}
@@ -799,7 +799,7 @@ static int i915_getparam(struct drm_device *dev, void *data,
value = dev->pdev->irq ? 1 : 0;
break;
case I915_PARAM_ALLOW_BATCHBUFFER:
- value = dev_priv->allow_batchbuffer ? 1 : 0;
+ value = dev_priv->dri1.allow_batchbuffer ? 1 : 0;
break;
case I915_PARAM_LAST_DISPATCH:
value = READ_BREADCRUMB(dev_priv);
@@ -882,7 +882,7 @@ static int i915_setparam(struct drm_device *dev, void *data,
dev_priv->tex_lru_log_granularity = param->value;
break;
case I915_SETPARAM_ALLOW_BATCHBUFFER:
- dev_priv->allow_batchbuffer = param->value;
+ dev_priv->dri1.allow_batchbuffer = param->value ? 1 : 0;
break;
case I915_SETPARAM_NUM_USED_FENCES:
if (param->value > dev_priv->num_fence_regs ||
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index d60b573..aaa038a 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -397,7 +397,6 @@ typedef struct drm_i915_private {
struct work_struct hotplug_work;
int tex_lru_log_granularity;
- int allow_batchbuffer;
unsigned int sr01, adpa, ppcr, dvob, dvoc, lvds;
int vblank_pipe;
int num_pipe;
@@ -630,6 +629,7 @@ typedef struct drm_i915_private {
u32 saveMCHBAR_RENDER_STANDBY;
u32 savePCH_PORT_HOTPLUG;
+
struct {
/** Bridge to intel-gtt-ko */
const struct intel_gtt *gtt;
@@ -739,6 +739,15 @@ typedef struct drm_i915_private {
size_t object_memory;
u32 object_count;
} mm;
+
+ /* Old dri1 support infrastructure, beware the dragons ya fools entering
+ * here! */
+ struct {
+ unsigned allow_batchbuffer : 1;
+ } dri1;
+
+ /* Kernel Modesetting */
+
struct sdvo_device_mapping sdvo_mappings[2];
/* indicate whether the LVDS_BORDER should be enabled or not */
unsigned int lvds_border_bits;
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 0d53eac..f06316f 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -3606,7 +3606,7 @@ int i915_gem_init(struct drm_device *dev)
}
/* Allow hardware batchbuffers unless told otherwise. */
- dev_priv->allow_batchbuffer = 1;
+ dev_priv->dri1.allow_batchbuffer = 1;
return 0;
}
--
1.7.7.6
next prev parent reply other threads:[~2012-04-26 22:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 21:28 [PATCH 00/17] dri1 dragon slaughtering, v2 Daniel Vetter
2012-04-26 21:28 ` [PATCH 01/17] drm/i915: move dri1 vblank stubs to i915_dma.c Daniel Vetter
2012-04-26 21:28 ` Daniel Vetter [this message]
2012-04-26 21:28 ` [PATCH 03/17] drm/i915 disallow physical batchbuffers for KMS Daniel Vetter
2012-04-26 21:28 ` [PATCH 04/17] drm/i915: rip out dev_priv->tex_lru_log_granularity Daniel Vetter
2012-04-26 21:28 ` [PATCH 05/17] drm/i915: remove LP_RING&friends from modeset code Daniel Vetter
2012-04-26 21:28 ` [PATCH 06/17] drm/i915: kill intel_clear_scanline_wait Daniel Vetter
2012-04-26 21:28 ` [PATCH 07/17] drm/i915: rip out dri1 breadcrumb updates from gen5+ irq handlers Daniel Vetter
2012-04-26 21:28 ` [PATCH 08/17] drm/i915: move dri1 irq ioctl code to i915_dma.c Daniel Vetter
2012-04-26 21:28 ` [PATCH 09/17] drm/i915: extract dri1 breadcrumb update from irq handler Daniel Vetter
2012-04-26 21:28 ` [PATCH 10/17] drm/i915: move LP_RING&friends to i915_dma.c Daniel Vetter
2012-04-26 21:28 ` [PATCH 11/17] drm/i915: disallow clip rects on gen5+ Daniel Vetter
2012-04-26 21:28 ` [PATCH 12/17] drm/i915: move the ips code to intel_pm.c Daniel Vetter
2012-04-26 21:28 ` [PATCH 13/17] drm/i915: move rps/emon function declarations Daniel Vetter
2012-04-26 21:28 ` [PATCH 14/17] drm/i915: kill pointless clearing of dev_priv->hws_map Daniel Vetter
2012-04-26 21:28 ` [PATCH 15/17] drm/i915: rework legacy GFX HWS handling Daniel Vetter
2012-04-26 21:28 ` [PATCH 16/17] drm/i915: fixup __iomem mixups in ringbuffer.c Daniel Vetter
2012-04-26 21:28 ` [PATCH 17/17] drm/i915: move pnv|ilk_gem_mem_freq to intel_pm.c Daniel Vetter
2012-05-02 11:49 ` [PATCH 00/17] dri1 dragon slaughtering, v2 Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335475697-3069-3-git-send-email-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox