From: Chris Wilson <chris@chris-wilson.co.uk>
To: Adam Jackson <ajax@redhat.com>, Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/dp: Remove eDP special cases from bandwidth checks
Date: Thu, 10 May 2012 19:40:23 +0100 [thread overview]
Message-ID: <1336675242_230176@CP5-2952> (raw)
In-Reply-To: <1318872559.7630.56.camel@atropine>
On Mon, 17 Oct 2011 13:29:18 -0400, Adam Jackson <ajax@redhat.com> wrote:
> On Fri, 2011-10-14 at 23:13 -0700, Keith Packard wrote:
> > On Fri, 14 Oct 2011 12:43:50 -0400, Adam Jackson <ajax@redhat.com> wrote:
> >
> > > These were just working around the math being wrong.
> >
> > One wonders whether this might break some machines which are currently
> > working. Should we emit an error or something if an eDP panel asks for
> > the impossible?
>
> Probably, but I think in cases where that happens we should be
> considering the driver to be broken before the panel. No one's going to
> manufacture hardware that can't run Windows.
Sigh, This patch did introduce a number of regressions, notably
https://bugs.freedesktop.org/show_bug.cgi?id=45801
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-05-10 18:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 16:43 [PATCH 1/2] drm/i915/dp: Fix the math in intel_dp_link_required Adam Jackson
2011-10-14 16:43 ` [PATCH 2/2] drm/i915/dp: Remove eDP special cases from bandwidth checks Adam Jackson
2011-10-15 6:13 ` Keith Packard
2011-10-17 17:29 ` Adam Jackson
2012-05-10 18:40 ` Chris Wilson [this message]
2012-05-10 19:14 ` Daniel Vetter
2011-10-15 6:11 ` [PATCH 1/2] drm/i915/dp: Fix the math in intel_dp_link_required Keith Packard
2011-10-17 17:03 ` Adam Jackson
2011-10-17 22:46 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336675242_230176@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=ajax@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox