From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>, Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Introduce for_each_ring() macro
Date: Fri, 11 May 2012 10:26:11 +0100 [thread overview]
Message-ID: <1336728393_239965@CP5-2952> (raw)
In-Reply-To: <20120511090012.GB5085@phenom.ffwll.local>
On Fri, 11 May 2012 11:00:12 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, May 10, 2012 at 03:39:32PM -0700, Ben Widawsky wrote:
> > Sneaky way to get rid of the warning you never liked... I won't forget
> > this.
>
> I concur that killing that warnings is sneaky ;-) Can't we just keep them
> - the ring->obj check should do the right thing? Or what exactly do I
> miss?
Other than I'm not a fan of those warnings; completely in the wrong
spot. If you want a warning that i915_gpu_idle is not doing its job
even in the face of a wedged GPU (so in fact i915_gem_reset failing),
it would be better to place those warnings inside i915_gpu_idle.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2012-05-11 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 22:27 [PATCH] drm/i915: Introduce for_each_ring() macro Chris Wilson
2012-05-10 21:21 ` Chris Wilson
2012-05-10 22:39 ` Ben Widawsky
2012-05-10 23:18 ` Chris Wilson
2012-05-11 9:00 ` Daniel Vetter
2012-05-11 9:26 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336728393_239965@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox