From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Convert BUG_ON(!pll->active) and friends to a WARN
Date: Sun, 13 May 2012 21:15:51 +0100 [thread overview]
Message-ID: <1336940179_9886@CP5-2952> (raw)
In-Reply-To: <20120513200810.GG4720@phenom.ffwll.local>
On Sun, 13 May 2012 22:08:10 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Sun, May 13, 2012 at 08:16:12PM +0100, Chris Wilson wrote:
> > Turn a fatal lockup into a merely blank display with lots of shouty
> > messages.
> >
> > v2: Whilst in the area, convert the other BUG_ON into less fatal errors.
> > In particular, note that we may be called on a PCH platform not using
> > PLLs, such as Haswell, and so we do not always want to BUG_ON(!pll)
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Ok, I guess you want me to drop v1 of this again. I'll wait for a bit of
> feedback on these two then (and the tested-by from qa on the 2nd one).
Up to you, I thought that the original patch was overshadowed by the
your change request and little reason for it to be split. It would be
good to get QA's tested-by on the second patch at any rate.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-05-13 20:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 8:54 [PATCH 1/2] drm/i915: Convert BUG_ON(!pll->active) to a WARN Chris Wilson
2012-05-13 8:54 ` [PATCH 2/2] drm/i915: Enable the PCH PLL for all generations after link training Chris Wilson
2012-05-13 14:08 ` Daniel Vetter
2012-05-13 14:25 ` Chris Wilson
2012-05-13 23:35 ` Eugeni Dodonov
2012-05-13 23:39 ` Eugeni Dodonov
2012-05-14 15:12 ` Jesse Barnes
2012-05-14 15:23 ` Chris Wilson
2012-05-13 13:42 ` [PATCH 1/2] drm/i915: Convert BUG_ON(!pll->active) to a WARN Daniel Vetter
2012-05-13 19:16 ` [PATCH] drm/i915: Convert BUG_ON(!pll->active) and friends " Chris Wilson
2012-05-13 20:08 ` Daniel Vetter
2012-05-13 20:15 ` Chris Wilson [this message]
2012-05-19 21:11 ` Daniel Vetter
2012-05-13 23:51 ` Eugeni Dodonov
2012-05-19 21:09 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336940179_9886@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox