From: Chris Wilson <chris@chris-wilson.co.uk>
To: Paulo Zanoni <przanoni@gmail.com>, intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: unlock mutex before intel_modeset_init_hw
Date: Fri, 18 May 2012 22:22:32 +0100 [thread overview]
Message-ID: <1337376154_107539@CP5-2952> (raw)
In-Reply-To: <1337374633-4438-1-git-send-email-przanoni@gmail.com>
On Fri, 18 May 2012 17:57:13 -0300, Paulo Zanoni <przanoni@gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Because on IVB, intel_modeset_init_hw calls gen6_enable_rps with locks
> the mutex. This problem broke suspend on my machine. It was introduced
> in the following commit:
>
> commit 2e1352cf196094f44e73776f41087f4c489ab936
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date: Wed May 9 11:56:28 2012 +0100
>
> drm/i915: gen6_enable_rps() wants to be called after ring initialisation
>
> This fix was actually suggested by Chris Wilson on a conversation, so
> the credit goes to him. I just bisected the problem, reported to him
> and tested his idea.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
My mistake, I thought I was being consistent with the other callsites,
when in fact it was the exact opposite.
Daniel, do you mind erasing the mistake from history and crediting Paulo
for v3? :)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-05-18 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 20:57 [PATCH] drm/i915: unlock mutex before intel_modeset_init_hw Paulo Zanoni
2012-05-18 21:22 ` Chris Wilson [this message]
2012-05-19 20:40 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337376154_107539@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox