From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>,
Jani Nikula <jani.nikula@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: hold forcewake around ring hw init
Date: Mon, 04 Jun 2012 10:21:14 +0100 [thread overview]
Message-ID: <1338801716_475258@CP5-2952> (raw)
In-Reply-To: <20120604091604.GB4978@phenom.ffwll.local>
On Mon, 4 Jun 2012 11:16:04 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Mon, Jun 04, 2012 at 12:04:41PM +0300, Jani Nikula wrote:
> >
> > Hi Daniel, please find a couple of comments inline.
>
> Oops, a clear case of -ENOTENOUGHCOFFEE. Thanks for catching these, I'll
> follow up with a v2 shortly.
Fwiw, the w/a looks harmless and is indeed advisable in cases where we
do a lot of writes (which does not really seem to apply here!)
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-06-04 9:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 8:40 [PATCH] drm/i915: hold forcewake around ring hw init Daniel Vetter
2012-06-04 9:04 ` Jani Nikula
2012-06-04 9:16 ` Daniel Vetter
2012-06-04 9:21 ` Chris Wilson [this message]
2012-06-04 9:18 ` Daniel Vetter
2012-06-04 9:39 ` Daniel Vetter
2012-06-04 12:47 ` Eugeni Dodonov
2012-06-04 18:26 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338801716_475258@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox